Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Unified Diff: media/cast/rtcp/rtcp_sender_unittest.cc

Issue 102413014: Cast:Splitting rtcp sender (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« media/cast/rtcp/rtcp_sender.h ('K') | « media/cast/rtcp/rtcp_sender.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/rtcp/rtcp_sender_unittest.cc
diff --git a/media/cast/rtcp/rtcp_sender_unittest.cc b/media/cast/rtcp/rtcp_sender_unittest.cc
index 16e9ee18ffb189abe25cb6b13eeafe2cb4d01eaf..ee107dd4909a59db66f0df9f26bfda5993319ada 100644
--- a/media/cast/rtcp/rtcp_sender_unittest.cc
+++ b/media/cast/rtcp/rtcp_sender_unittest.cc
@@ -77,28 +77,6 @@ class RtcpSenderTest : public ::testing::Test {
scoped_ptr<RtcpSender> rtcp_sender_;
};
-TEST_F(RtcpSenderTest, RtcpSenderReport) {
- RtcpSenderInfo sender_info;
- sender_info.ntp_seconds = kNtpHigh;
- sender_info.ntp_fraction = kNtpLow;
- sender_info.rtp_timestamp = kRtpTimestamp;
- sender_info.send_packet_count = kSendPacketCount;
- sender_info.send_octet_count = kSendOctetCount;
-
- // Sender report + c_name.
- TestRtcpPacketBuilder p;
- p.AddSr(kSendingSsrc, 0);
- p.AddSdesCname(kSendingSsrc, kCName);
- test_transport_.SetExpectedRtcpPacket(p.Packet(), p.Length());
-
- rtcp_sender_->SendRtcpFromRtpSender(RtcpSender::kRtcpSr,
- &sender_info,
- NULL,
- NULL);
-
- EXPECT_EQ(1, test_transport_.packet_count());
-}
-
TEST_F(RtcpSenderTest, RtcpReceiverReport) {
// Empty receiver report + c_name.
TestRtcpPacketBuilder p1;
@@ -135,114 +113,6 @@ TEST_F(RtcpSenderTest, RtcpReceiverReport) {
EXPECT_EQ(2, test_transport_.packet_count());
}
-TEST_F(RtcpSenderTest, RtcpSenderReportWithDlrr) {
- RtcpSenderInfo sender_info;
- sender_info.ntp_seconds = kNtpHigh;
- sender_info.ntp_fraction = kNtpLow;
- sender_info.rtp_timestamp = kRtpTimestamp;
- sender_info.send_packet_count = kSendPacketCount;
- sender_info.send_octet_count = kSendOctetCount;
-
- // Sender report + c_name + dlrr.
- TestRtcpPacketBuilder p1;
- p1.AddSr(kSendingSsrc, 0);
- p1.AddSdesCname(kSendingSsrc, kCName);
- p1.AddXrHeader(kSendingSsrc);
- p1.AddXrDlrrBlock(kSendingSsrc);
- test_transport_.SetExpectedRtcpPacket(p1.Packet(), p1.Length());
-
- RtcpDlrrReportBlock dlrr_rb;
- dlrr_rb.last_rr = kLastRr;
- dlrr_rb.delay_since_last_rr = kDelayLastRr;
-
- rtcp_sender_->SendRtcpFromRtpSender(
- RtcpSender::kRtcpSr | RtcpSender::kRtcpDlrr,
- &sender_info,
- &dlrr_rb,
- NULL);
-
- EXPECT_EQ(1, test_transport_.packet_count());
-}
-
-TEST_F(RtcpSenderTest, RtcpSenderReportWithDlrrAndLog) {
- RtcpSenderInfo sender_info;
- sender_info.ntp_seconds = kNtpHigh;
- sender_info.ntp_fraction = kNtpLow;
- sender_info.rtp_timestamp = kRtpTimestamp;
- sender_info.send_packet_count = kSendPacketCount;
- sender_info.send_octet_count = kSendOctetCount;
-
- // Sender report + c_name + dlrr + sender log.
- TestRtcpPacketBuilder p;
- p.AddSr(kSendingSsrc, 0);
- p.AddSdesCname(kSendingSsrc, kCName);
- p.AddXrHeader(kSendingSsrc);
- p.AddXrDlrrBlock(kSendingSsrc);
- p.AddSenderLog(kSendingSsrc);
- p.AddSenderFrameLog(kRtcpSenderFrameStatusSentToNetwork, kRtpTimestamp);
-
- test_transport_.SetExpectedRtcpPacket(p.Packet(), p.Length());
-
- RtcpDlrrReportBlock dlrr_rb;
- dlrr_rb.last_rr = kLastRr;
- dlrr_rb.delay_since_last_rr = kDelayLastRr;
-
- RtcpSenderFrameLogMessage sender_frame_log;
- sender_frame_log.frame_status = kRtcpSenderFrameStatusSentToNetwork;
- sender_frame_log.rtp_timestamp = kRtpTimestamp;
-
- RtcpSenderLogMessage sender_log;
- sender_log.push_back(sender_frame_log);
-
- rtcp_sender_->SendRtcpFromRtpSender(
- RtcpSender::kRtcpSr | RtcpSender::kRtcpDlrr | RtcpSender::kRtcpSenderLog,
- &sender_info,
- &dlrr_rb,
- &sender_log);
-
- EXPECT_EQ(1, test_transport_.packet_count());
- EXPECT_TRUE(sender_log.empty());
-}
-
-TEST_F(RtcpSenderTest, RtcpSenderReporWithTooManyLogFrames) {
- RtcpSenderInfo sender_info;
- sender_info.ntp_seconds = kNtpHigh;
- sender_info.ntp_fraction = kNtpLow;
- sender_info.rtp_timestamp = kRtpTimestamp;
- sender_info.send_packet_count = kSendPacketCount;
- sender_info.send_octet_count = kSendOctetCount;
-
- // Sender report + c_name + sender log.
- TestRtcpPacketBuilder p;
- p.AddSr(kSendingSsrc, 0);
- p.AddSdesCname(kSendingSsrc, kCName);
- p.AddSenderLog(kSendingSsrc);
-
- for (int i = 0; i < 359; ++i) {
- p.AddSenderFrameLog(kRtcpSenderFrameStatusSentToNetwork,
- kRtpTimestamp + i * 90);
- }
- test_transport_.SetExpectedRtcpPacket(p.Packet(), p.Length());
-
-
- RtcpSenderLogMessage sender_log;
- for (int j = 0; j < 400; ++j) {
- RtcpSenderFrameLogMessage sender_frame_log;
- sender_frame_log.frame_status = kRtcpSenderFrameStatusSentToNetwork;
- sender_frame_log.rtp_timestamp = kRtpTimestamp + j * 90;
- sender_log.push_back(sender_frame_log);
- }
-
- rtcp_sender_->SendRtcpFromRtpSender(
- RtcpSender::kRtcpSr | RtcpSender::kRtcpSenderLog,
- &sender_info,
- NULL,
- &sender_log);
-
- EXPECT_EQ(1, test_transport_.packet_count());
- EXPECT_EQ(41u, sender_log.size());
-}
-
TEST_F(RtcpSenderTest, RtcpReceiverReportWithRrtr) {
// Receiver report with report block + c_name.
TestRtcpPacketBuilder p;
« media/cast/rtcp/rtcp_sender.h ('K') | « media/cast/rtcp/rtcp_sender.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698