Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102413014: Cast:Splitting rtcp sender (Closed)

Created:
7 years ago by mikhal1
Modified:
7 years ago
Reviewers:
pwestin
CC:
chromium-reviews, hclam+watch_chromium.org, cbentzel+watch_chromium.org, mikhal+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, pwestin+watch_google.com, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Cast:Splitting rtcp sender Moving sender packet building code into the net/rtcp folder. Namespaces and renaming will be added in a follow up cl for the entire folder. BUG=327482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241965

Patch Set 1 #

Total comments: 3

Patch Set 2 : nits #

Patch Set 3 : removing unused var #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+673 lines, -409 lines) Patch
M media/cast/cast.gyp View 1 2 3 4 chunks +64 lines, -64 lines 0 comments Download
M media/cast/net/cast_net_defines.h View 2 chunks +44 lines, -1 line 0 comments Download
A media/cast/net/rtcp/rtcp_builder.h View 1 chunk +78 lines, -0 lines 0 comments Download
A media/cast/net/rtcp/rtcp_builder.cc View 1 chunk +265 lines, -0 lines 0 comments Download
A media/cast/net/rtcp/rtcp_builder_unittest.cc View 1 2 1 chunk +208 lines, -0 lines 0 comments Download
M media/cast/rtcp/rtcp.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/cast/rtcp/rtcp.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M media/cast/rtcp/rtcp.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M media/cast/rtcp/rtcp_defines.h View 4 chunks +1 line, -52 lines 0 comments Download
M media/cast/rtcp/rtcp_receiver_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.h View 1 4 chunks +1 line, -15 lines 0 comments Download
M media/cast/rtcp/rtcp_sender.cc View 5 chunks +1 line, -143 lines 0 comments Download
M media/cast/rtcp/rtcp_sender_unittest.cc View 2 chunks +0 lines, -130 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
mikhal1
Please review, -Mikhal https://codereview.chromium.org/102413014/diff/1/media/cast/net/rtcp/rtcp_builder.cc File media/cast/net/rtcp/rtcp_builder.cc (right): https://codereview.chromium.org/102413014/diff/1/media/cast/net/rtcp/rtcp_builder.cc#newcode24 media/cast/net/rtcp/rtcp_builder.cc:24: All the tests here were taken ...
7 years ago (2013-12-18 17:43:32 UTC) #1
pwestin
lgtm iassuming fixed nits https://codereview.chromium.org/102413014/diff/1/media/cast/rtcp/rtcp.gyp File media/cast/rtcp/rtcp.gyp (right): https://codereview.chromium.org/102413014/diff/1/media/cast/rtcp/rtcp.gyp#newcode23 media/cast/rtcp/rtcp.gyp:23: '<(DEPTH)/media/cast/net/rtcp/rtcp_builder.cc', indentation
7 years ago (2013-12-18 18:59:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/102413014/40001
7 years ago (2013-12-19 03:32:42 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=204924
7 years ago (2013-12-19 03:55:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/102413014/40001
7 years ago (2013-12-19 16:44:05 UTC) #5
commit-bot: I haz the power
Failed to apply patch for media/cast/cast.gyp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years ago (2013-12-19 16:44:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/102413014/60001
7 years ago (2013-12-19 17:21:18 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=238508
7 years ago (2013-12-19 20:44:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhal@chromium.org/102413014/60001
7 years ago (2013-12-19 20:48:56 UTC) #9
commit-bot: I haz the power
7 years ago (2013-12-19 22:59:17 UTC) #10
Message was sent while issue was closed. 
Change committed as 241965

Powered by Google App Engine
This is Rietveld 408576698