content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc - Issue 1024113003: Add multi-planar functions to GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

Issue 1024113003: Add multi-planar functions to GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Comment fix. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc b/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

index 419dfeed92fa7c1ca0fa73a40b4a92dd7cc9df53..ba55d78349e7b44111439920cad1f98c682d4797 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc

@@ -106,10 +106,12 @@ TEST_P(GpuMemoryBufferImplTest, Map) {

ASSERT_TRUE(buffer);

EXPECT_FALSE(buffer->IsMapped());

- void* memory = buffer->Map();

- ASSERT_TRUE(memory);

+ void* memory;

+ bool rv = buffer->Map(&memory);

+ ASSERT_TRUE(rv);

EXPECT_TRUE(buffer->IsMapped());

- uint32 stride = buffer->GetStride();

+ uint32 stride;

+ buffer->GetStride(&stride);

EXPECT_GE(stride, width_in_bytes);

memcpy(memory, data.get(), width_in_bytes);

EXPECT_EQ(memcmp(memory, data.get(), width_in_bytes), 0);