Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc

Issue 1024113003: Add multi-planar functions to GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: reveman@ comments. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
diff --git a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
index 9e37d55bddc5657aeaa874e344b4b2107b38e52d..690656faeb170b62a093d207b107edcb5cdd0565 100644
--- a/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
+++ b/gpu/command_buffer/tests/gl_gpu_memory_buffer_unittest.cc
@@ -78,7 +78,11 @@ TEST_F(GpuMemoryBufferTest, Lifecycle) {
gfx::Size(kImageWidth, kImageHeight), gfx::GpuMemoryBuffer::RGBA_8888));
// Map buffer for writing.
- uint8* mapped_buffer = static_cast<uint8*>(buffer->Map());
+ void* data;
+ bool map_completed = buffer->Map(&data);
reveman 2015/03/24 22:16:53 nit: map_succeeded?
emircan 2015/03/24 22:45:16 Changed it to "rv" to be consistent with the rest.
+ DCHECK(map_completed);
+
+ uint8* mapped_buffer = static_cast<uint8*>(data);
ASSERT_TRUE(mapped_buffer != NULL);
// Assign a value to each pixel.

Powered by Google App Engine
This is Rietveld 408576698