content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc - Issue 1024113003: Add multi-planar functions to GpuMemoryBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc

Issue 1024113003: Add multi-planar functions to GpuMemoryBuffer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: reveman@ comments. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc ('K') | « content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.h ('k') | content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h » ('j') | content/common/gpu/client/gpu_memory_buffer_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc

diff --git a/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc b/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc

index 24dfb3f38bd1a9547549ca53103b2d4e819d0fb0..1dc9df1ee6c2071322a2c8121d0101ec89bd0beb 100644

--- a/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc

+++ b/content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_buffer.cc

@@ -31,18 +31,17 @@ GpuMemoryBufferImplOzoneNativeBuffer::CreateFromHandle(

handle.id, size, format, callback));

}

-void* GpuMemoryBufferImplOzoneNativeBuffer::Map() {

+bool GpuMemoryBufferImplOzoneNativeBuffer::Map(void** data) {

NOTREACHED();

- return NULL;

+ return false;

}

void GpuMemoryBufferImplOzoneNativeBuffer::Unmap() {

NOTREACHED();

}

-uint32 GpuMemoryBufferImplOzoneNativeBuffer::GetStride() const {

+void GpuMemoryBufferImplOzoneNativeBuffer::GetStride(uint32* stride) const {

NOTREACHED();

- return 0;

}

gfx::GpuMemoryBufferHandle GpuMemoryBufferImplOzoneNativeBuffer::GetHandle()