Add multi-planar functions to GpuMemoryBuffer

content/common/gpu/client/gpu_memory_buffer_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/gpu/client/gpu_memory_buffer_impl.h"
 
 #include "base/logging.h"
 #include "base/numerics/safe_math.h"
 #include "content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h"
 #include "ui/gl/gl_bindings.h"
@@ skipping 12 matching lines @@
 
 namespace content {
 
 GpuMemoryBufferImpl::GpuMemoryBufferImpl(gfx::GpuMemoryBufferId id,
                                          const gfx::Size& size,
                                          Format format,
                                          const DestructionCallback& callback)
     : id_(id),
       size_(size),
       format_(format),
+      num_planes_(NumberOfPlanesForGpuMemoryBufferFormat(format)),
       callback_(callback),
       mapped_(false),
       destruction_sync_point_(0) {
 }
 
 GpuMemoryBufferImpl::~GpuMemoryBufferImpl() {
   callback_.Run(destruction_sync_point_);
 }
 
 // static
@@ skipping 30 matching lines @@
 // static
 GpuMemoryBufferImpl* GpuMemoryBufferImpl::FromClientBuffer(
     ClientBuffer buffer) {
   return reinterpret_cast<GpuMemoryBufferImpl*>(buffer);
 }
 
 // static
 bool GpuMemoryBufferImpl::StrideInBytes(size_t width,
                                         Format format,
                                         size_t* stride_in_bytes) {
-  base::CheckedNumeric<size_t> s = width;

[reveman, 2015/03/23 22:24:01]

Is this change needed?

[emircan, 2015/03/24 16:52:27]

I was trying to change the function signature to work with uint32*, but realized
the usage with size_t is more common later. It is a leftover, sorry for missing
that.

+  base::CheckedNumeric<uint32> s = width;
   switch (format) {
     case ATCIA:
     case DXT5:
       *stride_in_bytes = width;
       return true;
     case ATC:
     case DXT1:
     case ETC1:
       DCHECK_EQ(width % 2, 0U);
       s /= 2;
@@ skipping 10 matching lines @@
         return false;
 
       *stride_in_bytes = s.ValueOrDie();
       return true;
   }
 
   NOTREACHED();
   return false;
 }
 
+size_t GpuMemoryBufferImpl::GetNumberOfPlanes() const {
+  return num_planes_;
+}
+
 gfx::GpuMemoryBuffer::Format GpuMemoryBufferImpl::GetFormat() const {
   return format_;
 }
 
 bool GpuMemoryBufferImpl::IsMapped() const {
   return mapped_;
 }
 
 ClientBuffer GpuMemoryBufferImpl::AsClientBuffer() {
   return reinterpret_cast<ClientBuffer>(this);
 }
 
+// static
+size_t GpuMemoryBufferImpl::NumberOfPlanesForGpuMemoryBufferFormat(
+    gfx::GpuMemoryBuffer::Format format) {
+  switch (format) {
+    case gfx::GpuMemoryBuffer::Format::ATC:
+    case gfx::GpuMemoryBuffer::Format::ATCIA:
+    case gfx::GpuMemoryBuffer::Format::DXT1:
+    case gfx::GpuMemoryBuffer::Format::DXT5:
+    case gfx::GpuMemoryBuffer::Format::ETC1:
+    case gfx::GpuMemoryBuffer::Format::RGBA_8888:
+    case gfx::GpuMemoryBuffer::Format::RGBX_8888:
+    case gfx::GpuMemoryBuffer::Format::BGRA_8888:
+      return 1;
+    default:
+      NOTREACHED();
+      return 0;
+  }
+}
+
 }  // namespace content