Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1024113002: Revert of PDF: remove last use of SkPDFImage (Closed)

Created:
5 years, 9 months ago by reed1
Modified:
5 years, 9 months ago
Reviewers:
hal.canary, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of PDF: remove last use of SkPDFImage (patchset #5 id:120001 of https://codereview.chromium.org/950633003/) Reason for revert: static void draw(SkCanvas* canvas, const SkPaint& p, const SkBitmap& src, SkColorType colorType, const char text[]) { SkASSERT(src.colorType() == colorType); canvas->drawBitmap(src, 0.0f, 0.0f); canvas->drawText(text, strlen(text), 0.0f, 12.0f, p); } This assert is firing, at least on macs, where all images get decoded into 32bit at the moment. Original issue's description: > PDF: remove last use of SkPDFImage > > Add a GM. > > BUG=skia:255 > > Committed: https://skia.googlesource.com/skia/+/86ad8d643624a55b02e529100bbe4e2940115fa1 TBR=mtklein@google.com,halcanary@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:255 Committed: https://skia.googlesource.com/skia/+/1b600d3446b3d236bfa06cf116ec41960bea6ac8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1010 lines, -378 lines) Patch
D gm/all_bitmap_configs.cpp View 1 chunk +0 lines, -93 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/pdf.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M src/pdf/SkPDFBitmap.h View 2 chunks +7 lines, -4 lines 0 comments Download
M src/pdf/SkPDFBitmap.cpp View 4 chunks +179 lines, -272 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 3 chunks +4 lines, -8 lines 0 comments Download
A src/pdf/SkPDFImage.h View 1 chunk +91 lines, -0 lines 0 comments Download
A src/pdf/SkPDFImage.cpp View 1 chunk +727 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
reed1
Created Revert of PDF: remove last use of SkPDFImage
5 years, 9 months ago (2015-03-20 17:02:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024113002/1
5 years, 9 months ago (2015-03-20 17:03:25 UTC) #2
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 17:03:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/1b600d3446b3d236bfa06cf116ec41960bea6ac8

Powered by Google App Engine
This is Rietveld 408576698