Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1024093002: [ARM64] [turbofan] Support Float64Min and Float64Max. (Closed)

Created:
5 years, 9 months ago by jbramley
Modified:
5 years, 9 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev, m.m.capewell
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ARM64] [turbofan] Support Float64Min and Float64Max. ARM64 support for Float64Min and Float64Max machine operators (https://codereview.chromium.org/998283002/) using fmin and fmax. BUG= Committed: https://crrev.com/b9ef7d42678d486123445aa17459ff778625bcb0 Cr-Commit-Position: refs/heads/master@{#27361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -3 lines) Patch
M src/compiler/arm64/code-generator-arm64.cc View 2 chunks +9 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +16 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbramley
5 years, 9 months ago (2015-03-20 16:58:46 UTC) #2
Benedikt Meurer
Nice. LGTM
5 years, 9 months ago (2015-03-22 13:49:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024093002/1
5 years, 9 months ago (2015-03-23 09:55:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-23 10:25:17 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 10:25:31 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b9ef7d42678d486123445aa17459ff778625bcb0
Cr-Commit-Position: refs/heads/master@{#27361}

Powered by Google App Engine
This is Rietveld 408576698