Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1024083003: Use StyleNode in StockMenu (Closed)

Created:
5 years, 9 months ago by abarth-chromium
Modified:
5 years, 9 months ago
Reviewers:
eseidel
CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use StyleNode in StockMenu StockMenu was creating a container for the sole purpose of applying style to PopupMenu. Now we just use a StyleNode. Also, I've reverted the change to make box-sizing default to border-box. It turns out that CL wasn't effective because we didn't use the initialBoxSizing function to initialize box sizing. I've made us use initialBoxSizing but switch the default back to content-box because actually using border-box breaks a bunch of stuff. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7f4cd25744763f72bf7039a28ef129a363f99652

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -16 lines) Patch
M sky/engine/core/rendering/style/RenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/style/StyleBoxData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/stocks-fn/lib/stock_menu.dart View 1 chunk +10 lines, -12 lines 0 comments Download
M sky/framework/components/popup_menu.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 9 months ago (2015-03-20 17:06:51 UTC) #1
eseidel
lgtm
5 years, 9 months ago (2015-03-20 17:15:47 UTC) #2
abarth-chromium
5 years, 9 months ago (2015-03-20 17:16:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7f4cd25744763f72bf7039a28ef129a363f99652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698