Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1024083002: [Ozone-Drm] Notify cursor of channel established last (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
Reviewers:
spang
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ozone-Drm] Notify cursor of channel established last The cursor is special since movements don't need to be routed to the UI thread, instead they are directly dispatched to the GPU process from the IO-thread. During the recovery of a crashed GPU process, the windowing state needs to be re-created on the new GPU. As such we need to make sure that the windows are re-created on the GPU before the cursor can send targeted events (to a specific window). BUG=468485 Committed: https://crrev.com/d818104f773a0d49ba316e0aa8ab1629052d8c97 Cr-Commit-Position: refs/heads/master@{#321645}

Patch Set 1 #

Patch Set 2 : Typo #

Total comments: 2

Patch Set 3 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M ui/ozone/platform/drm/host/drm_cursor.h View 1 2 2 chunks +1 line, -5 lines 1 comment Download
M ui/ozone/platform/drm/host/drm_cursor.cc View 1 2 2 chunks +2 lines, -10 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M ui/ozone/platform/drm/host/drm_gpu_platform_support_host.cc View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/ozone_platform_drm.cc View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M ui/ozone/platform/drm/ozone_platform_gbm.cc View 1 2 2 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
dnicoara
5 years, 9 months ago (2015-03-20 16:10:33 UTC) #2
spang
https://codereview.chromium.org/1024083002/diff/20001/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h (right): https://codereview.chromium.org/1024083002/diff/20001/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h#newcode34 ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:34: void RegisterCursorHandler(GpuPlatformSupportHost* cursor_handler); I think this should say DrmCursor*. ...
5 years, 9 months ago (2015-03-20 16:51:45 UTC) #3
dnicoara
https://codereview.chromium.org/1024083002/diff/20001/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h File ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h (right): https://codereview.chromium.org/1024083002/diff/20001/ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h#newcode34 ui/ozone/platform/drm/host/drm_gpu_platform_support_host.h:34: void RegisterCursorHandler(GpuPlatformSupportHost* cursor_handler); On 2015/03/20 16:51:45, spang wrote: > ...
5 years, 9 months ago (2015-03-20 17:27:51 UTC) #4
spang
https://codereview.chromium.org/1024083002/diff/40001/ui/ozone/platform/drm/host/drm_cursor.h File ui/ozone/platform/drm/host/drm_cursor.h (left): https://codereview.chromium.org/1024083002/diff/40001/ui/ozone/platform/drm/host/drm_cursor.h#oldcode32 ui/ozone/platform/drm/host/drm_cursor.h:32: class DrmCursor : public CursorDelegateEvdev, public GpuPlatformSupportHost { remove ...
5 years, 9 months ago (2015-03-20 19:44:11 UTC) #5
spang
lgtm
5 years, 9 months ago (2015-03-20 19:44:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024083002/40001
5 years, 9 months ago (2015-03-20 21:33:11 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-20 22:02:47 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 22:03:21 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d818104f773a0d49ba316e0aa8ab1629052d8c97
Cr-Commit-Position: refs/heads/master@{#321645}

Powered by Google App Engine
This is Rietveld 408576698