[strong] checking of this & super in constructors

test/cctest/test-parsing.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 5560 matching lines @@
   };
   RunParserSyncTest(sloppy_context_data, data, kSuccess, NULL, 0, always_flags,
                     arraysize(always_flags));
   RunParserSyncTest(strict_context_data, data, kSuccess, NULL, 0, always_flags,
                     arraysize(always_flags));
   RunParserSyncTest(strong_context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
 }
 
 
-TEST(StrongSuperCalls) {
+TEST(StrongConstructorThis) {
+  const char* sloppy_context_data[][2] = {{"", ""}, {NULL}};
+  const char* strict_context_data[][2] = {{"'use strict';", ""}, {NULL}};
+  const char* strong_context_data[][2] = {{"'use strong';", ""}, {NULL}};
+
+  const char* data[] = {
+      "class C extends Object { constructor() { this; } }",
+      "class C extends Object { constructor() { this.a; } }",
+      "class C extends Object { constructor() { this['a']; } }",
+      "class C extends Object { constructor() { this.a = 0; } }",
+      "class C extends Object { constructor() { (this); } }",

[marja, 2015/03/23 10:20:07]

I'm not sure if this test is testing what it looks like at the first glance.. Is
parsing failing for all of these because there's no super call? So
strong_super_call_misplaced? Or is it failing because of
strong_constructor_this, or is it mixed (the this.a = 0 failing because of the
former, at least)?

For the "malformed this expression" case the interesting tests would be like:

super()
if (1) this.a = 0;

etc., right?

I think it would be worthwhile to split this test into 2 cases, where the first
set is failing because there's no super call (even though the this assignment is
valid) -- you can put the super call into context_data, so, test that it's
succeeding w/ context_data_with_super_call, but failing w/
context_data_without_super_call. The second set would then be failing with both
contexts, because the assignment is malformed.

[rossberg, 2015/04/20 17:21:11]

Oops, yes, this test wasn't supposed to test missing super calls. That's already
tested separately below.

+      "class C extends Object { constructor() { this(); } }",
+      // TODO(rossberg): arrow functions not handled yet.
+      // "class C extends Object { constructor() { () => this; } }",
+      "class C extends Object { constructor() { this.a = 0, 0; } }",
+      "class C extends Object { constructor() { (this.a = 0); } }",
+      // "class C extends Object { constructor() { (() => this.a = 0)(); } }",
+      "class C extends Object { constructor() { { this.a = 0; } } }",
+      "class C extends Object { constructor() { if (1) this.a = 0; } }",
+      "class C extends Object { constructor() { label: this.a = 0; } }",
+      NULL};
+
+  static const ParserFlag always_flags[] = {
+      kAllowStrongMode, kAllowHarmonyClasses, kAllowHarmonyObjectLiterals,
+      kAllowHarmonyArrowFunctions
+  };
+  RunParserSyncTest(sloppy_context_data, data, kError, NULL, 0, always_flags,
+                    arraysize(always_flags));
+  RunParserSyncTest(strict_context_data, data, kSuccess, NULL, 0, always_flags,
+                    arraysize(always_flags));
+  RunParserSyncTest(strong_context_data, data, kError, NULL, 0, always_flags,
+                    arraysize(always_flags));
+}
+
+
+TEST(StrongConstructorSuper) {
   const char* sloppy_context_data[][2] = {{"", ""}, {NULL}};
   const char* strict_context_data[][2] = {{"'use strict';", ""}, {NULL}};
   const char* strong_context_data[][2] = {{"'use strong';", ""}, {NULL}};
 
   const char* data[] = {
       "class C extends Object { constructor() {} }",
+      "class C extends Object { constructor() { super.a; } }",
+      "class C extends Object { constructor() { super['a']; } }",
+      "class C extends Object { constructor() { super.a = 0; } }",
+      "class C extends Object { constructor() { (super.a); } }",
+      // TODO(rossberg): arrow functions do not handle super yet.
+      // "class C extends Object { constructor() { () => super.a; } }",
+      "class C extends Object { constructor() { super(), 0; } }",
       "class C extends Object { constructor() { (super()); } }",
-      "class C extends Object { constructor() { (() => super())(); } }",
+      // "class C extends Object { constructor() { (() => super())(); } }",
       "class C extends Object { constructor() { { super(); } } }",
       "class C extends Object { constructor() { if (1) super(); } }",
+      "class C extends Object { constructor() { label: super(); } }",
       "class C extends Object { constructor() { super(), super(); } }",
       "class C extends Object { constructor() { super(); super(); } }",
       "class C extends Object { constructor() { super(); (super()); } }",
       "class C extends Object { constructor() { super(); { super() } } }",
+      "class C extends Object { constructor() { this.a = 0, super(); } }",
+      "class C extends Object { constructor() { this.a = 0; super(); } }",
+      "class C extends Object { constructor() { super(this.a = 0); } }",
       NULL};
 
   static const ParserFlag always_flags[] = {
       kAllowStrongMode, kAllowHarmonyClasses, kAllowHarmonyObjectLiterals,
       kAllowHarmonyArrowFunctions
   };
   RunParserSyncTest(sloppy_context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
   RunParserSyncTest(strict_context_data, data, kSuccess, NULL, 0, always_flags,
                     arraysize(always_flags));
   RunParserSyncTest(strong_context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
 }
 
 
 TEST(StrongConstructorReturns) {
   const char* sloppy_context_data[][2] = {{"", ""}, {NULL}};
   const char* strict_context_data[][2] = {{"'use strict';", ""}, {NULL}};
   const char* strong_context_data[][2] = {{"'use strong';", ""}, {NULL}};
 
   const char* data[] = {
       "class C extends Object { constructor() { super(); return {}; } }",
       "class C extends Object { constructor() { super(); { return {}; } } }",
       "class C extends Object { constructor() { super(); if (1) return {}; } }",
       "class C extends Object { constructor() { return; super(); } }",
       "class C extends Object { constructor() { { return; } super(); } }",
       "class C extends Object { constructor() { if (0) return; super(); } }",
+      "class C extends Object { constructor() { return; this.a = 0; } }",
+      "class C extends Object { constructor() { { return; } this.a = 0; } }",
+      "class C extends Object { constructor() { if (0) return; this.a = 0; } }",
       NULL};
 
   static const ParserFlag always_flags[] = {
       kAllowStrongMode, kAllowHarmonyClasses, kAllowHarmonyObjectLiterals
   };
   RunParserSyncTest(sloppy_context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
   RunParserSyncTest(strict_context_data, data, kSuccess, NULL, 0, always_flags,
                     arraysize(always_flags));
   RunParserSyncTest(strong_context_data, data, kError, NULL, 0, always_flags,
@@ skipping 10 matching lines @@
       "(a/*\n*/=> a)(1)",
       "((a)\n=> a)(1)",
       "((a)/*\n*/=> a)(1)",
       "((a, b)\n=> a + b)(1, 2)",
       "((a, b)/*\n*/=> a + b)(1, 2)",
       NULL};
   static const ParserFlag always_flags[] = {kAllowHarmonyArrowFunctions};
   RunParserSyncTest(context_data, data, kError, NULL, 0, always_flags,
                     arraysize(always_flags));
 }