Make VTTParser::collectDigitsToInt non-copying

Make VTTParser::collectDigitsToInt non-copying

Modify VTTParser::collectDigits to simply count the number of digits and
advance the position. Rename it to scanDigits and make it local to the
compilation unit.
Convert users of collectDigits to use scanDigits instead. For
collectDigitsToInt this means that there's no longer a need to copy the
digits into a temporary String. Similarly for parseFloatPercentageValue.

Also fixes a minor issue in parseFloatPercentageValue where the endpoints
(0 and 100) were excluded from the range of valid values rather than
included.

BUG=305317
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163160

[Mike West, 2013-12-04 08:17:42]

This is better, thanks for poking at it. One note, otherwise LGTM.

https://codereview.chromium.org/102403002/diff/1/Source/core/html/track/vtt/V...
File Source/core/html/track/vtt/VTTParser.cpp (right):

https://codereview.chromium.org/102403002/diff/1/Source/core/html/track/vtt/V...
Source/core/html/track/vtt/VTTParser.cpp:104: unsigned digitsAfterDot;
If you default this to 0, you can drop the 'else' clause in the following 'if'.

[fs, 2013-12-04 08:51:23]

On 2013/12/04 08:17:42, Mike West wrote:
> This is better, thanks for poking at it. One note, otherwise LGTM.
> 
>
https://codereview.chromium.org/102403002/diff/1/Source/core/html/track/vtt/V...
> File Source/core/html/track/vtt/VTTParser.cpp (right):
> 
>
https://codereview.chromium.org/102403002/diff/1/Source/core/html/track/vtt/V...
> Source/core/html/track/vtt/VTTParser.cpp:104: unsigned digitsAfterDot;
> If you default this to 0, you can drop the 'else' clause in the following
'if'.

Done. (I always do a dice-roll to pick one or the other ;-))

[commit-bot: I haz the power, 2013-12-04 08:55:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/fs@opera.com/102403002/20001

[commit-bot: I haz the power, 2013-12-04 10:15:01]

Change committed as 163160