Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 1024013002: Revert of Oilpan: fix webkit unit tests following r192243. (Closed)

Created:
5 years, 9 months ago by sof
Modified:
5 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, sof, eae+blinkwatch, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Oilpan: fix webkit unit tests following r192243. (patchset #2 id:20001 of https://codereview.chromium.org/1026753002/) Reason for revert: Breaks windows builder, http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder/builds/74953 Original issue's description: > Oilpan: fix webkit unit tests following r192243. > > TBR=oilpan-reviews > BUG=467890 > NOTRY=true TBR=oilpan-reviews@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=467890 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192252

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M Source/core/dom/ScriptRunnerTest.cpp View 2 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Created Revert of Oilpan: fix webkit unit tests following r192243.
5 years, 9 months ago (2015-03-20 13:43:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1024013002/1
5 years, 9 months ago (2015-03-20 13:43:30 UTC) #2
haraken
LGTM
5 years, 9 months ago (2015-03-20 13:43:38 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 13:44:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192252

Powered by Google App Engine
This is Rietveld 408576698