[AiS] Added option to put a space between answer values

chrome/browser/ui/views/omnibox/omnibox_result_view.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_
 #define CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
 #include "chrome/browser/bitmap_fetcher/bitmap_fetcher_service.h"
 #include "components/omnibox/autocomplete_match.h"
-#include "components/omnibox/suggestion_answer.h"
 #include "third_party/skia/include/core/SkColor.h"
 #include "ui/gfx/animation/animation_delegate.h"
 #include "ui/gfx/animation/slide_animation.h"
 #include "ui/gfx/font_list.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/views/controls/image_view.h"
 #include "ui/views/view.h"
 
 class LocationBarView;
 class OmniboxPopupContentsView;
@@ skipping 129 matching lines @@
   // Returns the offset at which the contents of the |match| should be displayed
   // within the text bounds. The directionality of UI and match contents is used
   // to determine the offset relative to the correct edge.
   int GetDisplayOffset(const AutocompleteMatch& match,
                        bool is_ui_rtl,
                        bool is_match_contents_rtl) const;
 
   int GetAnswerLineHeight() const;
   int GetContentLineHeight() const;
 
-  void AppendAnswerText(const SuggestionAnswer::TextField& text_field);
+  // Adds styled text to |description_rendertext_|.

[Peter Kasting, 2015/03/24 01:05:35]

Nit: Can you flesh this out more?  How is the text styled?  For example:

Adds |text| to |description_rendertext_|.  |text_type| is an index into the
kTextStyles constant defined in the .cc file and is used to style the text,
including setting the font size, color, and baseline style.  See the TextStyle
struct in the .cc file for more.

[dschuyler, 2015/03/24 01:26:47]

Thanks!

Done.

+  void AppendAnswerText(const base::string16& text, int text_type);

[Peter Kasting, 2015/03/24 01:05:35]

Nit: |text_style| might be a better name for this arg.

Now that we're passing this to a function defined in the .h I _almost_ want to
make it an enum instead of an int, but I think an int is probably still OK for
now.

[dschuyler, 2015/03/24 01:26:47]

I call the TextStyle instance text_style in the same function.  Also the
function being called to get the text_type is type().  Maybe not be best names
ever, but there somewhat consistent in this space.  (pun intended).

[Peter Kasting, 2015/03/24 01:44:56]

Fair enough, but this highlights for me that there's a type mismatch problem
here.  You take this arg as an int in this function, but GetTextStyle() in the
.cc file takes a size_t.  The conversion is done implicitly.

Probably GetTextStyle() should take an int and clamp values of 0 or less to 1. 
(Right now, calling that function with a type of 0 is actually going to crash
Chrome, which seems bad.)

[dschuyler, 2015/03/24 02:20:10]

Done.

 
   static int default_icon_size_;
 
   // Default values cached here, may be overridden using the setters above.
   int edge_item_padding_;
   int item_padding_;
 
   // This row's model and model index.
   OmniboxPopupContentsView* model_;
   size_t model_index_;
@@ skipping 33 matching lines @@
   mutable scoped_ptr<gfx::RenderText> keyword_description_rendertext_;
 
   mutable int separator_width_;
 
   base::WeakPtrFactory<OmniboxResultView> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OmniboxResultView);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_OMNIBOX_OMNIBOX_RESULT_VIEW_H_