Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issue 1023983002: Fix background colour for Cocoa app list on hover (Closed)

Created:
5 years, 9 months ago by tapted
Modified:
5 years, 9 months ago
Reviewers:
Andre
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, mac-views-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix background colour for Cocoa app list on hover This color changed recently for the toolkit-views app list, but the Cocoa app list isn't ready for it yet. The Cocoa-specific kHighlightedColor was only used in apps_search_results_controller.mm, so move it there. kSelectedColor is used there but also in apps_grid_view_item.mm. However, the latter users a composited draw, so it's fine with the transparent background views uses. BUG=469051 Committed: https://crrev.com/b98970ffc6ea2c1b6840d6cb00eedcf96d5758f5 Cr-Commit-Position: refs/heads/master@{#321573}

Patch Set 1 #

Patch Set 2 : Actually just fix it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M ui/app_list/app_list_constants.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M ui/app_list/cocoa/apps_search_results_controller.mm View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tapted
Hi Andre, could you take a look at this one? (looking for a PST reviewer ...
5 years, 9 months ago (2015-03-20 10:30:10 UTC) #2
Andre
LGTM
5 years, 9 months ago (2015-03-20 15:34:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023983002/20001
5 years, 9 months ago (2015-03-20 15:35:32 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-20 15:51:58 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 15:52:57 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b98970ffc6ea2c1b6840d6cb00eedcf96d5758f5
Cr-Commit-Position: refs/heads/master@{#321573}

Powered by Google App Engine
This is Rietveld 408576698