Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: remoting/webapp/app_remoting/js/app_remoting.js

Issue 1023943004: Use a separate window to notify the user that permissions are required. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/app_remoting/js/app_remoting.js
diff --git a/remoting/webapp/app_remoting/js/app_remoting.js b/remoting/webapp/app_remoting/js/app_remoting.js
index 83493ebf5e370678727c054bb3d800840b2ba9c3..2eb83775e7522820da048781865fe5e18b59ff11 100644
--- a/remoting/webapp/app_remoting/js/app_remoting.js
+++ b/remoting/webapp/app_remoting/js/app_remoting.js
@@ -91,8 +91,6 @@ remoting.AppRemoting.prototype.init = function() {
this.contextMenu_ = new remoting.ApplicationContextMenu(adapter);
this.keyboardLayoutsMenu_ = new remoting.KeyboardLayoutsMenu(adapter);
this.windowActivationMenu_ = new remoting.WindowActivationMenu(adapter);
-
- remoting.LoadingWindow.show();
Jamie 2015/03/21 01:18:23 Showing this dialog in init() is not correct, as w
garykac 2015/03/23 23:25:33 Sounds good.
};
/**
@@ -105,6 +103,8 @@ remoting.AppRemoting.prototype.init = function() {
* start-up.
*/
remoting.AppRemoting.prototype.start = function(connector, token) {
+ remoting.LoadingWindow.show();
+
/** @type {remoting.AppRemoting} */
var that = this;

Powered by Google App Engine
This is Rietveld 408576698