Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: util/file/file_writer.h

Issue 1023943003: crashpad_database_util: Accept --new-report=- to read a new report from standard input (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@crashpad_database_util_new_report
Patch Set: Fix Windows Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/file/file_reader.cc ('k') | util/file/string_file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/file/file_writer.h
diff --git a/util/file/file_writer.h b/util/file/file_writer.h
index fd88ce08c54e99d946a45194894795e51115f488..a0d547e8bea67be97df70de90c9f1fa97fbf8055 100644
--- a/util/file/file_writer.h
+++ b/util/file/file_writer.h
@@ -44,6 +44,8 @@ struct WritableIoVec {
//! semantics matching the underlying platform (POSIX or Windows).
class FileWriterInterface : public virtual FileSeekerInterface {
public:
+ virtual ~FileWriterInterface() {}
+
//! \brief Wraps LoggingWriteFile(), or provides an implementation with
//! identical semantics.
//!
@@ -61,9 +63,6 @@ class FileWriterInterface : public virtual FileSeekerInterface {
//!
//! \note The contents of \a iovecs are undefined when this method returns.
virtual bool WriteIoVec(std::vector<WritableIoVec>* iovecs) = 0;
-
- protected:
- ~FileWriterInterface() {}
};
//! \brief A file writer backed by a FileHandle.
@@ -83,7 +82,7 @@ class FileWriterInterface : public virtual FileSeekerInterface {
class WeakFileHandleFileWriter : public FileWriterInterface {
public:
explicit WeakFileHandleFileWriter(FileHandle file_handle);
- ~WeakFileHandleFileWriter();
+ ~WeakFileHandleFileWriter() override;
// FileWriterInterface:
bool Write(const void* data, size_t size) override;
@@ -117,7 +116,7 @@ class WeakFileHandleFileWriter : public FileWriterInterface {
class FileWriter : public FileWriterInterface {
public:
FileWriter();
- ~FileWriter();
+ ~FileWriter() override;
// FileWriterInterface:
« no previous file with comments | « util/file/file_reader.cc ('k') | util/file/string_file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698