Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1023943002: X87: [turbofan] Implement throwing exceptions into TurboFan code. (Closed)

Created:
5 years, 9 months ago by chunyang.dai
Modified:
5 years, 9 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Implement throwing exceptions into TurboFan code. port 1382879f29bd71c36aeda2421e867c4cdd232a0d (r27016). oringinal commit message: [turbofan] Implement throwing exceptions into TurboFan code. This extends the stack unwinding logic to respect optimized frames and perform a lookup in the handler table to find handlers. It also contains fixes to the API call stubs to allow a stack walk while promoting scheduled exceptions. BUG= Committed: https://crrev.com/f395ccd6db25138ae3e132bc4fe617a793f6b4e8 Cr-Commit-Position: refs/heads/master@{#27342}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M src/x87/code-stubs-x87.cc View 5 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL.
5 years, 9 months ago (2015-03-20 09:17:25 UTC) #2
Weiliang
lgtm
5 years, 9 months ago (2015-03-20 12:52:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023943002/1
5 years, 9 months ago (2015-03-20 12:52:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 13:45:08 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 13:45:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f395ccd6db25138ae3e132bc4fe617a793f6b4e8
Cr-Commit-Position: refs/heads/master@{#27342}

Powered by Google App Engine
This is Rietveld 408576698