Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1023923002: Files.app: Add JobEventRouter class that handles Job related events of Files.app. (Closed)

Created:
5 years, 9 months ago by hirono
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files.app: Add JobEventRouter class that handles Job related events of Files.app. The following CL replaces the existing code with the new class. BUG=469039 TEST=JobEventRouterTest Committed: https://crrev.com/0de936155933f21f1b8c2a8c9842f0f9c2263041 Cr-Commit-Position: refs/heads/master@{#321532}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -0 lines) Patch
A chrome/browser/chromeos/extensions/file_manager/job_event_router.h View 1 chunk +89 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/extensions/file_manager/job_event_router.cc View 1 chunk +136 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/extensions/file_manager/job_event_router_unittest.cc View 1 chunk +173 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
@fukino PTAL, thanks!
5 years, 9 months ago (2015-03-20 04:39:49 UTC) #2
fukino
lgtm. Thank you!
5 years, 9 months ago (2015-03-20 06:39:23 UTC) #3
hirono
On 2015/03/20 06:39:23, fukino wrote: > lgtm. Thank you! Thanks!
5 years, 9 months ago (2015-03-20 06:40:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023923002/1
5 years, 9 months ago (2015-03-20 06:41:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 07:59:33 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 08:00:18 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0de936155933f21f1b8c2a8c9842f0f9c2263041
Cr-Commit-Position: refs/heads/master@{#321532}

Powered by Google App Engine
This is Rietveld 408576698