Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 1023893002: Fix for clang build warnings: undefined variables if !USE_UDEV. (Closed)

Created:
5 years, 9 months ago by gunsch
Modified:
5 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix for clang build warnings: undefined variables if !USE_UDEV. R=agoode@chromium.org,wolenetz@chromium.org BUG=None Committed: https://crrev.com/504b1da3fb365a0c59af25ba44dbeb998b764a5e Cr-Commit-Position: refs/heads/master@{#321526}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M media/midi/midi_manager_alsa.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
gunsch
5 years, 9 months ago (2015-03-19 23:43:56 UTC) #1
Adam Goode
lgtm
5 years, 9 months ago (2015-03-20 00:09:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023893002/1
5 years, 9 months ago (2015-03-20 00:14:47 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-20 00:14:49 UTC) #6
gunsch
+toyoshim: can you take a quick look for OWNERS?
5 years, 9 months ago (2015-03-20 01:29:29 UTC) #8
Takashi Toyoshima
lgtm
5 years, 9 months ago (2015-03-20 05:52:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023893002/1
5 years, 9 months ago (2015-03-20 05:52:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 06:32:38 UTC) #12
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 06:33:05 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/504b1da3fb365a0c59af25ba44dbeb998b764a5e
Cr-Commit-Position: refs/heads/master@{#321526}

Powered by Google App Engine
This is Rietveld 408576698