Don't track windows that were interacted (restored/minimized) by user while wallpaper picker applic…

Don't track windows that were interacted (restored/minimized) by user while wallpaper picker application is opening.

BUG=323252
TEST steps:
1. Open a browser window.
2. Open the wallpaper picker application while keeping the browser window open. The browser window gets minimized as expected.
3. Restore the browser window and minimize it again
4. Close the wallpaper picker application. The browser window should not be restored since user has minimized it intentionally.

Committed: https://crrev.com/8e0cb8aa1d38307d800d83d1f8ee50924743e879
Cr-Commit-Position: refs/heads/master@{#322327}

[xdai1, 2015-03-24 00:00:04]

xdai@chromium.org changed reviewers:
+ bshe@chromium.org

[xdai1, 2015-03-24 00:00:04]

Biao, could you please help to review the CL please? Thanks!

[bshe, 2015-03-24 17:21:16]

On 2015/03/24 00:00:04, xdai1 wrote:
> Biao, could you please help to review the CL please? Thanks!

lgtm with nits

[bshe, 2015-03-24 17:21:42]

https://codereview.chromium.org/1023863003/diff/1/chrome/browser/chromeos/ext...
File chrome/browser/chromeos/extensions/wallpaper_private_api.cc (right):

https://codereview.chromium.org/1023863003/diff/1/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/wallpaper_private_api.cc:259: void
WindowStateManager::OnWindowStackingChanged(aura::Window* window) {
I am not familiar with this function and when will it be called. As long as it
called when the window state changed, it should be fine. You probably want to
add another reviewer who is familiar with this to take a look.

https://codereview.chromium.org/1023863003/diff/1/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/wallpaper_private_api.cc:262: for
(UserIDHashWindowListMap::iterator iter =
you can probably use auto here since it is allowed.

https://codereview.chromium.org/1023863003/diff/1/chrome/browser/chromeos/ext...
chrome/browser/chromeos/extensions/wallpaper_private_api.cc:265: if
(iter->second.find(window) != iter->second.end())
you can directly call erase here. If it's not found, erase should be a noop.

[xdai1, 2015-03-24 18:37:04]

xdai@chromium.org changed reviewers:
+ skuhne@chromium.org

[xdai1, 2015-03-24 18:37:05]

Thanks for the review, Biao!
skuhne@, could you help to take a look at the CL please? Thanks.

[Mr4D (OOO till 08-26), 2015-03-25 00:41:42]

This looks fine to me!

However - looking at the wallpaper_private_api_unittest.cc shows that it should
be fairly easy to add a test like 
WallpaperPrivateApiUnittest.HideAndRestoreWindows to see that this works. Could
you add such a test?

[xdai1, 2015-03-25 23:26:00]

Patchset #3 (id:40001) has been deleted

[xdai1, 2015-03-25 23:28:10]

On 2015/03/25 00:41:42, Mr4D wrote:
> This looks fine to me!
> 
> However - looking at the wallpaper_private_api_unittest.cc shows that it
should
> be fairly easy to add a test like 
> WallpaperPrivateApiUnittest.HideAndRestoreWindows to see that this works.
Could
> you add such a test?

Thanks Stefan! I've added the test, could you please take another look?

[Mr4D (OOO till 08-26), 2015-03-25 23:42:53]

Thanks for adding the test!

LGTM!

[xdai1, 2015-03-26 05:19:37]

The CQ bit was checked by xdai@chromium.org

[xdai1, 2015-03-26 05:19:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/1023863003/#ps60001
(title: "Add unit test.")

[commit-bot: I haz the power, 2015-03-26 05:20:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1023863003/60001

[commit-bot: I haz the power, 2015-03-26 05:23:19]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-03-26 05:24:28]

Patchset 3 (id:??) landed as
https://crrev.com/8e0cb8aa1d38307d800d83d1f8ee50924743e879
Cr-Commit-Position: refs/heads/master@{#322327}