Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 1023843002: Sync: support implicit permanent folders in commits. (Closed)

Created:
5 years, 9 months ago by stanisc
Modified:
5 years, 9 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync: support implicit permanent folders in commits. Traversal::AddUncommittedParentsAndTheirPredecessors walks the hierarchy to sort commits which is not necessary for any types except bookmarks. We've seen some crashes here when implicit permanent folders were turned on alpha server. I reproduced the crash by planting an empty parent ID in the database. The fix avoids traversing the hierarchy for committed items with unset parent IDs. Verified that this has stopped the crash locally and successfully committed the item. BUG=438313 Committed: https://crrev.com/8d56b3a917a92081971e361b1939deff131149fd Cr-Commit-Position: refs/heads/master@{#321472}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -25 lines) Patch
M sync/engine/directory_commit_contribution_unittest.cc View 1 chunk +9 lines, -7 lines 0 comments Download
M sync/engine/get_commit_ids.cc View 6 chunks +31 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stanisc
5 years, 9 months ago (2015-03-19 22:08:11 UTC) #2
pavely
lgtm
5 years, 9 months ago (2015-03-19 23:40:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023843002/1
5 years, 9 months ago (2015-03-19 23:45:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 23:59:33 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 00:00:25 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d56b3a917a92081971e361b1939deff131149fd
Cr-Commit-Position: refs/heads/master@{#321472}

Powered by Google App Engine
This is Rietveld 408576698