 Chromium Code Reviews
 Chromium Code Reviews Issue 
            1023843002:
    Sync: support implicit permanent folders in commits.  (Closed)
    
  
    Issue 
            1023843002:
    Sync: support implicit permanent folders in commits.  (Closed) 
  | DescriptionSync: support implicit permanent folders in commits.
Traversal::AddUncommittedParentsAndTheirPredecessors walks the
hierarchy to sort commits which is not necessary for any types
except bookmarks.
We've seen some crashes here when implicit permanent folders
were turned on alpha server. I reproduced the crash by planting
an empty parent ID in the database.
The fix avoids traversing the hierarchy for committed items with
unset parent IDs. Verified that this has stopped the crash
locally and successfully committed the item.
BUG=438313
Committed: https://crrev.com/8d56b3a917a92081971e361b1939deff131149fd
Cr-Commit-Position: refs/heads/master@{#321472}
   Patch Set 1 #
 Messages
    Total messages: 7 (2 generated)
     | ||||||||||||||||||||||||||||