Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023823002: Report Bluetooth adapter status to UMA. (Closed)

Created:
5 years, 9 months ago by bcwhite
Modified:
5 years, 9 months ago
Reviewers:
xiyuan, jwd
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Report Bluetooth adapter status to UMA. BUG=465855 Committed: https://crrev.com/d57670feef6381fa9bb93600d4d458665316e558 Cr-Commit-Position: refs/heads/master@{#321797}

Patch Set 1 #

Patch Set 2 : added missing static variable definition #

Patch Set 3 : disable BT after start on systems not yet supported #

Total comments: 2

Patch Set 4 : change class static to function static #

Total comments: 2

Patch Set 5 : added when-logged comment to histogram #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -9 lines) Patch
M chrome/browser/signin/easy_unlock_service.cc View 1 2 3 4 4 chunks +46 lines, -9 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
bcwhite
jwd@chromium.org: Please review changes in tools/metrics/ xiyuan@chromium.org: Please review changes in easy_unlock_service
5 years, 9 months ago (2015-03-20 19:10:58 UTC) #2
xiyuan
https://codereview.chromium.org/1023823002/diff/40001/chrome/browser/signin/easy_unlock_service.h File chrome/browser/signin/easy_unlock_service.h (right): https://codereview.chromium.org/1023823002/diff/40001/chrome/browser/signin/easy_unlock_service.h#newcode337 chrome/browser/signin/easy_unlock_service.h:337: static bool bluetooth_adapter_has_been_reported; How about declare this flag as ...
5 years, 9 months ago (2015-03-20 19:19:31 UTC) #3
bcwhite
https://codereview.chromium.org/1023823002/diff/40001/chrome/browser/signin/easy_unlock_service.h File chrome/browser/signin/easy_unlock_service.h (right): https://codereview.chromium.org/1023823002/diff/40001/chrome/browser/signin/easy_unlock_service.h#newcode337 chrome/browser/signin/easy_unlock_service.h:337: static bool bluetooth_adapter_has_been_reported; On 2015/03/20 19:19:31, xiyuan wrote: > ...
5 years, 9 months ago (2015-03-20 20:28:26 UTC) #4
xiyuan
lgtm
5 years, 9 months ago (2015-03-20 20:29:02 UTC) #5
jwd
lgtm https://codereview.chromium.org/1023823002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1023823002/diff/60001/tools/metrics/histograms/histograms.xml#newcode6655 tools/metrics/histograms/histograms.xml:6655: + Reports the type of Bluetooth adapter present ...
5 years, 9 months ago (2015-03-23 14:12:16 UTC) #6
bcwhite
https://codereview.chromium.org/1023823002/diff/60001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1023823002/diff/60001/tools/metrics/histograms/histograms.xml#newcode6655 tools/metrics/histograms/histograms.xml:6655: + Reports the type of Bluetooth adapter present in ...
5 years, 9 months ago (2015-03-23 14:27:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023823002/80001
5 years, 9 months ago (2015-03-23 17:08:58 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 9 months ago (2015-03-23 17:13:18 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 17:14:46 UTC) #12
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/d57670feef6381fa9bb93600d4d458665316e558
Cr-Commit-Position: refs/heads/master@{#321797}

Powered by Google App Engine
This is Rietveld 408576698