Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 1023813003: [iOS] Upstream ios/chrome/browser/find_in_page (Closed)

Created:
5 years, 9 months ago by droger
Modified:
5 years, 9 months ago
Reviewers:
jif
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@upstreamAutofill
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream ios/chrome/browser/find_in_page BUG=452495, 452492 Committed: https://crrev.com/d9a155a681818aa1538304146f694e0875c3270b Cr-Commit-Position: refs/heads/master@{#322349}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1931 lines, -0 lines) Patch
A ios/chrome/browser/find_in_page/find_in_page_controller.h View 1 chunk +68 lines, -0 lines 0 comments Download
A ios/chrome/browser/find_in_page/find_in_page_controller.mm View 1 chunk +357 lines, -0 lines 0 comments Download
A ios/chrome/browser/find_in_page/find_in_page_model.h View 1 chunk +39 lines, -0 lines 0 comments Download
A ios/chrome/browser/find_in_page/find_in_page_model.mm View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/chrome/browser/find_in_page/js_findinpage_manager.h View 1 chunk +70 lines, -0 lines 0 comments Download
A ios/chrome/browser/find_in_page/js_findinpage_manager.mm View 1 chunk +278 lines, -0 lines 0 comments Download
A ios/chrome/browser/find_in_page/resources/find_in_page.js View 1 chunk +964 lines, -0 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 3 chunks +22 lines, -0 lines 0 comments Download
M ios/web/ios_web.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A ios/web/public/web_state/crw_web_view_scroll_view_proxy.h View 1 chunk +95 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
droger
5 years, 9 months ago (2015-03-23 17:48:26 UTC) #2
droger
ping
5 years, 9 months ago (2015-03-26 08:48:59 UTC) #3
jif
On 2015/03/26 08:48:59, droger wrote: > ping lgtm.
5 years, 9 months ago (2015-03-26 09:32:37 UTC) #4
droger
Thanks for the review.
5 years, 9 months ago (2015-03-26 09:38:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023813003/1
5 years, 9 months ago (2015-03-26 09:39:11 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-26 10:32:31 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 10:33:42 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d9a155a681818aa1538304146f694e0875c3270b
Cr-Commit-Position: refs/heads/master@{#322349}

Powered by Google App Engine
This is Rietveld 408576698