Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1023803002: Enable ouputting results for passed tests on AMP. (Closed)

Created:
5 years, 9 months ago by mikecase (-- gone --)
Modified:
5 years, 7 months ago
Reviewers:
Ted C, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable ouputting results for passed tests on AMP. AMP had a bug outputting results if the output stream was too large. Therefore, we only were outputting test results for failed tests. This issue has been fixed (b/18981674) and this CL is to enable full test result outputting on AMP. BUG= Committed: https://crrev.com/803ff930a0556a59087e24c2a5461325c01185b9 Cr-Commit-Position: refs/heads/master@{#330892}

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : #

Patch Set 4 : Rebase, now that bug has been fixed for real. #

Total comments: 2

Patch Set 5 #

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -23 lines) Patch
M build/android/pylib/remote/device/remote_device_gtest_run.py View 1 2 3 2 chunks +0 lines, -6 lines 0 comments Download
M testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java View 1 2 3 4 5 4 chunks +2 lines, -17 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
mikecase (-- gone --)
5 years, 9 months ago (2015-03-19 21:04:41 UTC) #2
mikecase (-- gone --)
Adding tedchoc@ for a review of testing/android
5 years, 9 months ago (2015-03-19 21:18:39 UTC) #4
jbudorick
lgtm
5 years, 9 months ago (2015-03-19 21:43:14 UTC) #5
Ted C
lgtm
5 years, 9 months ago (2015-03-19 22:09:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023803002/1
5 years, 9 months ago (2015-03-19 22:11:34 UTC) #8
mikecase (-- gone --)
I uploaded this CL a month or two ago when I mistakenly thought the appurify ...
5 years, 7 months ago (2015-05-20 22:39:34 UTC) #10
jbudorick
lgtm https://codereview.chromium.org/1023803002/diff/60001/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java File testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java (left): https://codereview.chromium.org/1023803002/diff/60001/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java#oldcode156 testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java:156: sendStatus(0, mLogBundle); hm, why was this sending two ...
5 years, 7 months ago (2015-05-20 22:42:50 UTC) #11
Ted C
On 2015/05/20 22:42:50, jbudorick wrote: > lgtm > > https://codereview.chromium.org/1023803002/diff/60001/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java > File > testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java > ...
5 years, 7 months ago (2015-05-20 23:21:13 UTC) #12
mikecase (-- gone --)
https://codereview.chromium.org/1023803002/diff/60001/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java File testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java (left): https://codereview.chromium.org/1023803002/diff/60001/testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java#oldcode156 testing/android/native_test/java/src/org/chromium/native_test/NativeTestInstrumentationTestRunner.java:156: sendStatus(0, mLogBundle); On 2015/05/20 22:42:50, jbudorick wrote: > hm, ...
5 years, 7 months ago (2015-05-20 23:28:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023803002/60001
5 years, 7 months ago (2015-05-20 23:28:36 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/55052) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-20 23:34:44 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023803002/100001
5 years, 7 months ago (2015-05-21 00:07:33 UTC) #22
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-21 04:41:15 UTC) #23
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:42:32 UTC) #24
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/803ff930a0556a59087e24c2a5461325c01185b9
Cr-Commit-Position: refs/heads/master@{#330892}

Powered by Google App Engine
This is Rietveld 408576698