test/cctest/test-api.cc - Issue 1023783009: Revert of add access checks to receivers on function callbacks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-api.cc

Issue 1023783009: Revert of add access checks to receivers on function callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-api.cc

diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc

index 63378ba7d6417453445483ecbc4f40f4189d6653..0714e404b4fc6386ab0535f952717993c0de87f8 100644

--- a/test/cctest/test-api.cc

+++ b/test/cctest/test-api.cc

@@ -8279,11 +8279,8 @@

CHECK(result.IsEmpty());

result = CompileRun("get_x_w()");

CHECK(result.IsEmpty());

- {

- v8::TryCatch try_catch(env1->GetIsolate());

- CompileRun("this_x()");

- CHECK(try_catch.HasCaught());

- }

+ result = CompileRun("this_x()");

+ CHECK(v8_str("env2_x")->Equals(result));

// Reattach env2's proxy

env2 = Context::New(env1->GetIsolate(),

« no previous file with comments | « test/cctest/test-accessors.cc ('k') | no next file » | no next file with comments »