Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: src/objects.cc

Issue 1023783009: Revert of add access checks to receivers on function callbacks (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/objects.h ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index 720af0864a1fd19fa788bf929eede2685d602f27..23f2eb39de9201ee53c46f996bfe5e3621d8af3d 100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -241,28 +241,21 @@
// TODO(dcarney): CallOptimization duplicates this logic, merge.
-Handle<Object> FunctionTemplateInfo::GetCompatibleReceiver(
- Isolate* isolate, Handle<Object> receiver, bool is_construct) {
+Object* FunctionTemplateInfo::GetCompatibleReceiver(Isolate* isolate,
+ Object* receiver) {
// API calls are only supported with JSObject receivers.
- if (!receiver->IsJSObject()) return isolate->factory()->null_value();
- auto js_receiver = Handle<JSObject>::cast(receiver);
- if (!is_construct && js_receiver->IsAccessCheckNeeded() &&
- !isolate->MayAccess(js_receiver)) {
- return isolate->factory()->null_value();
- }
+ if (!receiver->IsJSObject()) return isolate->heap()->null_value();
Object* recv_type = this->signature();
// No signature, return holder.
if (recv_type->IsUndefined()) return receiver;
FunctionTemplateInfo* signature = FunctionTemplateInfo::cast(recv_type);
// Check the receiver.
- for (PrototypeIterator iter(isolate, *receiver,
+ for (PrototypeIterator iter(isolate, receiver,
PrototypeIterator::START_AT_RECEIVER);
!iter.IsAtEnd(PrototypeIterator::END_AT_NON_HIDDEN); iter.Advance()) {
- if (signature->IsTemplateFor(iter.GetCurrent())) {
- return Handle<Object>(iter.GetCurrent(), isolate);
- }
- }
- return isolate->factory()->null_value();
+ if (signature->IsTemplateFor(iter.GetCurrent())) return iter.GetCurrent();
+ }
+ return isolate->heap()->null_value();
}
« no previous file with comments | « src/objects.h ('k') | test/cctest/test-accessors.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698