Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1023783009: Revert of add access checks to receivers on function callbacks (Closed)

Created:
5 years, 9 months ago by Michael Achenbach
Modified:
5 years, 9 months ago
Reviewers:
dcarney, Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of add access checks to receivers on function callbacks (patchset #5 id:80001 of https://codereview.chromium.org/1036743004/) Reason for revert: This seems to lead to lots of timeouts of layout tests, e.g.: http://build.chromium.org/p/client.v8/builders/V8-Blink%20Linux%2064/builds/2807 Original issue's description: > add access checks to receivers on function callbacks > > R=verwaest@chromium.org > BUG=468451 > LOG=N > > Committed: https://crrev.com/255528710b0a128eef7b66827d9ac43e44650ff4 > Cr-Commit-Position: refs/heads/master@{#27452} TBR=verwaest@chromium.org,dcarney@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=468451 Committed: https://crrev.com/f0d555b26ddbf7f825e78928197932b45db2ac8a Cr-Commit-Position: refs/heads/master@{#27457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -118 lines) Patch
M src/builtins.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +7 lines, -14 lines 0 comments Download
M test/cctest/test-accessors.cc View 1 chunk +0 lines, -83 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of add access checks to receivers on function callbacks
5 years, 9 months ago (2015-03-25 18:30:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023783009/1
5 years, 9 months ago (2015-03-25 18:31:17 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 18:31:42 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 18:32:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f0d555b26ddbf7f825e78928197932b45db2ac8a
Cr-Commit-Position: refs/heads/master@{#27457}

Powered by Google App Engine
This is Rietveld 408576698