Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1023783008: Migrate plugins to support new 'unobscured' rect interface (Closed)

Created:
5 years, 9 months ago by tommycli
Modified:
5 years, 8 months ago
Reviewers:
Bernhard Bauer, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate plugins to support new 'unobscured' rect interface Blink defines a new WebPlugin interface here: https://codereview.chromium.org/1033603007/ Currently both the deprecated and new versions are in the interface. This patch removes the deprecated usages so we can remove it in Blink as well. BUG=468142 Committed: https://crrev.com/ec81b43b5849ed5663faba04a8ed742dd67f3e0d Cr-Commit-Position: refs/heads/master@{#322839}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : further standardize parameter naming #

Patch Set 4 : 'git cl format' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -23 lines) Patch
M components/plugins/renderer/webview_plugin.h View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M components/plugins/renderer/webview_plugin.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 3 1 chunk +5 lines, -5 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.h View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download
M content/renderer/npapi/webplugin_impl.cc View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/pepper/pepper_webplugin_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_plugin.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/renderer/test_runner/test_plugin.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
piman
lgtm
5 years, 9 months ago (2015-03-25 22:09:37 UTC) #2
tommycli
bauerb: PTAL This won't be sent to CQ until the Blink patch lands and is ...
5 years, 9 months ago (2015-03-25 23:11:21 UTC) #4
Bernhard Bauer
lgtm
5 years, 9 months ago (2015-03-26 09:29:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023783008/60001
5 years, 8 months ago (2015-03-30 18:27:17 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-03-30 19:42:20 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 19:43:05 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ec81b43b5849ed5663faba04a8ed742dd67f3e0d
Cr-Commit-Position: refs/heads/master@{#322839}

Powered by Google App Engine
This is Rietveld 408576698