Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1023783005: Merge Crashpad to the 42.0.2311 branch (Closed)

Created:
5 years, 9 months ago by Mark Mentovai
Modified:
5 years, 9 months ago
Reviewers:
Robert Sesek, amineer
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, sadrul, kalyank, grt+watch_chromium.org, lcwu+watch_chromium.org, jam, darin-cc_chromium.org, arv+watch_chromium.org, asvitkine+watch_chromium.org, wfh+watch_chromium.org, gunsch+watch_chromium.org, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2311
Target Ref:
refs/pending/branch-heads/2311
Project:
chromium
Visibility:
Public.

Description

Merge Crashpad to the 42.0.2311 branch. The description from the original trunk commit to integrate Crashpad (https://codereview.chromium.org/1001103002, d413b2dcb549) was: > Crashpad!: Use the Crashpad client instead of Breakpad on Mac OS X. > > Crashpad is always compiled in to Chrome and its handler is always > enabled. It is only possible to enable uploads in official builds. > > Crashpad talks to the existing Breakpad server. There should be no > noticeable changes to crash reporting on the server side, except the > client IDs will all change to a new ID and will no longer be > synchronized with UMA client IDs. This is a one-time change. After > this, the client ID will remain stable within a single > --user-data-dir. > > This also includes follow-ups made after the original landing, tracked > under https://crbug.com/466964. This cherry-picks the following changes: 9470f6bca0fe Add additional move support to ScopedGeneric in the form of operator= d413b2dcb549 Crashpad!: Use the Crashpad client instead of Breakpad on Mac OS X 18fcae1dee18 Fix sign_versioned_dir.sh.in ffda27708784 Update Crashpad to e7b80a52f5b9832814485b58f66d4b13117a5186 d93ac0ad1929 Update Crashpad to 1d022a86db566613c11ff03ad6e791f9c01ffe88 4dc0534fabb2 Update Crashpad to 82bebb11de699550a36bf411737d01880e4a16a7 9f2fdc07d83f Update Crashpad to 5d0a133ecd6625f30c6491d502f12f26a0bef32d 8e57e5ba56c3 Don't show "requires Chrome restart" when toggling stats reporting preference on Mac OS X c67fa64ff085 Set a "metrics_client_id" crash key instead of "guid" on Mac OS X Crashpad changes included in "update Crashpad" commits include: 6bf80c3e4859 Add MinidumpCrashpadInfo::report_id e7b80a52f5b9 win: Add UUID::InitializeFromSystemUUID() 1d022a86db56 handler/mac: Support the in-Chromium component=shared_library configuration 98cca0e5fcb4 compat/mac: SDK compatibility for pre-Xcode 4.2 10.6 SDK 82bebb11de69 Update man pages d516689641d8 Update crashpad.doxy to Doxygen 1.8.9.1 1e12b471e376 Update mini_chromium to 6c49a5924dea c2502f45c9b2 doc: Add documentation-generating scripts to the Crashpad tree c052c97c7e2c Update crashpad_handler man page to document all options af9e78940e8c Allow man pages to link to each other 4bd97bb6db2a Document CrashpadInfo::set_simple_annotations() 6f4e6aacc885 Add crashpad_database_util and its man page 7fa250c9a238 Roll mini_chromium to 2f02dcc73536 8b4932e56034 Update mini_chromium to 31e989ac0b03 79ae055e50b1 Add Locking calls to file_io.h plus implementations and test 71deedee44d0 doxygen: Prevent the word Thread with a capital T from automatically linking to test::Thread. 0c704745dd65 Followup to https://codereview.chromium.org/1001673002/ 5d0a133ecd66 Tolerate weird cl_kernels modules TBR=amineer@chromium.org, rsesek@chromium.org BUG=386208, 390217, 415547, 427611, 466964, crashpad:12 Committed: https://chromium.googlesource.com/chromium/src/+/1fd9385ae419d92b1b4bf4001b1c319625fe6df5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+698 lines, -178 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +3 lines, -0 lines 0 comments Download
M base/mac/scoped_mach_port.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/scoped_generic.h View 2 chunks +10 lines, -4 lines 0 comments Download
M base/scoped_generic_unittest.cc View 2 chunks +18 lines, -1 line 0 comments Download
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/app/chrome_crash_reporter_client.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/app/chrome_crash_reporter_client_mac.mm View 2 chunks +0 lines, -23 lines 0 comments Download
M chrome/app/chrome_main_delegate.cc View 3 chunks +12 lines, -37 lines 0 comments Download
M chrome/browser/chrome_browser_main_mac.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/crash_upload_list.cc View 2 chunks +4 lines, -0 lines 0 comments Download
A chrome/browser/crash_upload_list_mac.h View 1 chunk +31 lines, -0 lines 0 comments Download
A chrome/browser/crash_upload_list_mac.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M chrome/browser/google/google_update_settings_posix.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/metrics/chrome_metrics_service_client.cc View 1 chunk +5 lines, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/browser_options.js View 1 chunk +9 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 2 chunks +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 2 chunks +9 lines, -19 lines 0 comments Download
M chrome/chrome_dll_bundle.gypi View 3 chunks +7 lines, -15 lines 0 comments Download
M chrome/common/child_process_logging_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/crash_keys.h View 2 chunks +14 lines, -5 lines 0 comments Download
M chrome/common/crash_keys.cc View 4 chunks +43 lines, -2 lines 0 comments Download
M chrome/installer/mac/sign_app.sh.in View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/installer/mac/sign_versioned_dir.sh.in View 3 chunks +6 lines, -0 lines 0 comments Download
M chrome/tools/build/mac/dump_product_syms View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/browser/metrics/cast_metrics_service_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/crash.gypi View 3 chunks +110 lines, -14 lines 0 comments Download
M components/crash/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
M components/crash/app/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/crash/app/breakpad_mac.mm View 2 chunks +0 lines, -9 lines 0 comments Download
M components/crash/app/crash_keys_win_unittest.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M components/crash/app/crash_reporter_client.h View 2 chunks +5 lines, -5 lines 0 comments Download
M components/crash/app/crash_reporter_client.cc View 2 chunks +2 lines, -5 lines 0 comments Download
A components/crash/app/crashpad_mac.h View 1 chunk +54 lines, -0 lines 0 comments Download
A components/crash/app/crashpad_mac.mm View 1 chunk +246 lines, -0 lines 0 comments Download
M components/metrics/metrics_service.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/metrics/metrics_service_client.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/content_shell.gypi View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/crashpad/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/crashpad/README.chromium View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Mark Mentovai
5 years, 9 months ago (2015-03-24 20:32:59 UTC) #2
Mark Mentovai
5 years, 9 months ago (2015-03-24 21:09:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1fd9385ae419d92b1b4bf4001b1c319625fe6df5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698