[DevTools] Move DevToolsAgent to RenderFrameImpl.

content/renderer/render_frame_impl.h

Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index cbe833d947714282085cf70b93a6cbfa66ad0837..f2fa83d7c4b6c2c7c28c8372e9e685e0b345a301 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -74,6 +74,7 @@ namespace content {
 
 class ChildFrameCompositingHelper;
 class CompositorDependencies;
+class DevToolsAgent;
 class ExternalPopupMenu;
 class GeolocationDispatcher;
 class ManifestManager;
@@ -739,6 +740,10 @@ class CONTENT_EXPORT RenderFrameImpl
   // case of the main frame, but not subframes).
   blink::WebLocalFrame* frame_;
 
+  // Whether this frame is a root of a subtree, where all frames live
+  // in the same process.

[nasko, 2015/03/25 22:26:04]

This comment is not quite correct. It is a local frame, which is rendered in a
process different than its parent. The subframes don't need to be all local,
they can be mix of remote and local.

[dgozman, 2015/03/26 13:25:49]

Updated comment. I also renamed this to |is_main_or_local_root_| to be aligned
with blink's counterpart, which does not count main frame as a local root.

+  bool is_local_root_;
+
   base::WeakPtr<RenderViewImpl> render_view_;
   int routing_id_;
   bool is_swapped_out_;
@@ -846,6 +851,9 @@ class CONTENT_EXPORT RenderFrameImpl
   bool contains_media_player_;
 #endif
 
+  // The devtools agent for this frame; only created for local frame roots.

[nasko, 2015/03/25 22:26:04]

nit: the frame is a local root, not that the local frame is root.

[dgozman, 2015/03/26 13:25:49]

Done.

+  DevToolsAgent* devtools_agent_;
+
   // The geolocation dispatcher attached to this frame, lazily initialized.
   GeolocationDispatcher* geolocation_dispatcher_;