Issue 1023783003: Remove suppression for HasSeekPenalty as the underlying problem is fixed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1023783003: Remove suppression for HasSeekPenalty as the underlying problem is fixed (Closed)

Created:
5 years, 9 months ago by benwells

Modified:
5 years, 9 months ago

Reviewers:
Alexander Potapenko

CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove suppression for HasSeekPenalty as the underlying problem is fixed The bug was fixed in https://crrev.com/8349cde788d93f75c7e82d88c6bc44a43bc19cf5 TBR=glider@chromium.org BUG=468631 Committed: https://crrev.com/a2207b55ae6ee577e7b6a12a248a614b4f971224 Cr-Commit-Position: refs/heads/master@{#321467}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -7 lines)			Patch
	M	tools/valgrind/drmemory/suppressions_full.txt	View		1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023783003/1

5 years, 9 months ago (2015-03-19 22:54:44 UTC) #3

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/a2207b55ae6ee577e7b6a12a248a614b4f971224 Cr-Commit-Position: refs/heads/master@{#321467}

5 years, 9 months ago (2015-03-19 23:20:10 UTC) #5

Alexander Potapenko

5 years, 9 months ago (2015-03-27 10:19:30 UTC) #6

Message was sent while issue was closed.

On 2015/03/19 23:20:10, I haz the power (commit-bot) wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/a2207b55ae6ee577e7b6a12a248a614b4f971224
> Cr-Commit-Position: refs/heads/master@{#321467}

LGTM

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages