Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1023753008: Disable some flags on threading tests that will break with --turbo-osr. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable some flags on threading tests that will break with --turbo-osr. R=vogelheim@chromium.org BUG= Committed: https://crrev.com/9be9e80c9c8ac0d44c2f4c806d08005695f25a35 Cr-Commit-Position: refs/heads/master@{#27455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M test/cctest/test-thread-termination.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
titzer
5 years, 9 months ago (2015-03-25 17:24:15 UTC) #1
vogelheim
lgtm
5 years, 9 months ago (2015-03-25 17:30:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023753008/1
5 years, 9 months ago (2015-03-25 17:32:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-25 18:06:03 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-25 18:06:16 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9be9e80c9c8ac0d44c2f4c806d08005695f25a35
Cr-Commit-Position: refs/heads/master@{#27455}

Powered by Google App Engine
This is Rietveld 408576698