Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1023703002: Let adb_gdb support privileged processes with a switch. (Closed)

Created:
5 years, 9 months ago by peterp
Modified:
5 years, 9 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let adb_gdb support privileged processes with a switch. Add "--privileged" and "--privileged=<num>" that works similar to "--sandboxed" to make it easier to debug the GPU process on Android. BUG=468697 Committed: https://crrev.com/c0d04ee2e6d53f043b5da00e98c724cdd6e2a8fa Cr-Commit-Position: refs/heads/master@{#321351}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M build/android/adb_gdb View 6 chunks +22 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
peterp
jbudorick: Does this look okay?
5 years, 9 months ago (2015-03-19 10:42:38 UTC) #2
jbudorick
lgtm
5 years, 9 months ago (2015-03-19 13:22:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023703002/1
5 years, 9 months ago (2015-03-19 13:29:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 13:56:04 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 13:56:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d04ee2e6d53f043b5da00e98c724cdd6e2a8fa
Cr-Commit-Position: refs/heads/master@{#321351}

Powered by Google App Engine
This is Rietveld 408576698