Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/compiler/lib/src/compiler.dart

Issue 1023673012: Emit diagnostics for bad NSM implementations (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | pkg/compiler/lib/src/warnings.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/compiler.dart
diff --git a/pkg/compiler/lib/src/compiler.dart b/pkg/compiler/lib/src/compiler.dart
index dcaea5943a723310bc0c5df3746f21a74b4a9248..fcdad0e10f332dde1fe25305f6fa2d52d3f72093 100644
--- a/pkg/compiler/lib/src/compiler.dart
+++ b/pkg/compiler/lib/src/compiler.dart
@@ -291,6 +291,7 @@ abstract class Backend {
bool get canHandleCompilationFailed;
void onResolutionComplete() {}
+ void onInferenceComplete() {}
sra1 2015/03/31 02:19:14 onTypeInferenceComplete() we could add other kind
ItemCompilationContext createItemCompilationContext() {
return new ItemCompilationContext();
@@ -362,7 +363,7 @@ abstract class Backend {
void registerRuntimeType(Enqueuer enqueuer, Registry registry) {}
/// Call this to register a `noSuchMethod` implementation.
- void registerNoSuchMethod(Element noSuchMethodElement) {}
+ void registerNoSuchMethod(FunctionElement noSuchMethodElement) {}
/// Call this method to enable support for `noSuchMethod`.
void enableNoSuchMethod(Enqueuer enqueuer) {}
@@ -1611,6 +1612,8 @@ abstract class Compiler implements DiagnosticListener {
if (stopAfterTypeInference) return;
+ backend.onInferenceComplete();
+
log('Compiling...');
phase = PHASE_COMPILING;
// TODO(johnniwinther): Move these to [CodegenEnqueuer].
« no previous file with comments | « no previous file | pkg/compiler/lib/src/js_backend/backend.dart » ('j') | pkg/compiler/lib/src/warnings.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698