[Extensions] Fix report abuse field trial crash

[Extensions] Fix report abuse field trial crash

Field trials can only be initialized once, so the FactoryGet() method cannot
be called each time to check the value of the trial.

BUG=470278
Committed: https://crrev.com/47e60f2d7430c3710daea8526dca88756fd111e1
Cr-Commit-Position: refs/heads/master@{#322212}

[Devlin, 2015-03-25 16:18:36]

rdevlin.cronin@chromium.org changed reviewers:
+ mek@chromium.org

[Marijn Kruisselbrink, 2015-03-25 16:45:25]

lgtm

[Devlin, 2015-03-25 16:45:46]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2015-03-25 16:46:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1023673011/1

[commit-bot: I haz the power, 2015-03-25 19:48:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-03-25 19:49:25]

Patchset 1 (id:??) landed as
https://crrev.com/47e60f2d7430c3710daea8526dca88756fd111e1
Cr-Commit-Position: refs/heads/master@{#322212}

[Alexei Svitkine (slow), 2015-03-31 20:50:52]

asvitkine@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Alexei Svitkine (slow), 2015-03-31 20:50:53]

https://codereview.chromium.org/1023673011/diff/1/chrome/browser/extensions/e...
File chrome/browser/extensions/extension_uninstall_dialog.cc (right):

https://codereview.chromium.org/1023673011/diff/1/chrome/browser/extensions/e...
chrome/browser/extensions/extension_uninstall_dialog.cc:138: // TODO(devlin):
Turn on this field trial. See crbug.com/441377.
The client-side API to create a field trial, like you're doing here is
discouraged.

It's best to control the trial from the server-side, in which case you don't
need this whole block.

Happy to answer any question on how to do this.

[Devlin, 2015-03-31 21:02:43]

On 2015/03/31 20:50:53, Alexei Svitkine wrote:
>
https://codereview.chromium.org/1023673011/diff/1/chrome/browser/extensions/e...
> File chrome/browser/extensions/extension_uninstall_dialog.cc (right):
> 
>
https://codereview.chromium.org/1023673011/diff/1/chrome/browser/extensions/e...
> chrome/browser/extensions/extension_uninstall_dialog.cc:138: // TODO(devlin):
> Turn on this field trial. See crbug.com/441377.
> The client-side API to create a field trial, like you're doing here is
> discouraged.
> 
> It's best to control the trial from the server-side, in which case you don't
> need this whole block.
> 
> Happy to answer any question on how to do this.

Heard the same from Ilya after this landed, and changed it to be appropriate in
https://codereview.chromium.org/1024493003/. :)

[Alexei Svitkine (slow), 2015-03-31 21:04:19]

Great, thanks!

On Tue, Mar 31, 2015 at 5:02 PM, <rdevlin.cronin@chromium.org> wrote:

> On 2015/03/31 20:50:53, Alexei Svitkine wrote:
>
> https://codereview.chromium.org/1023673011/diff/1/chrome/
> browser/extensions/extension_uninstall_dialog.cc
>
>> File chrome/browser/extensions/extension_uninstall_dialog.cc (right):
>>
>
>
> https://codereview.chromium.org/1023673011/diff/1/chrome/
> browser/extensions/extension_uninstall_dialog.cc#newcode138
>
>> chrome/browser/extensions/extension_uninstall_dialog.cc:138: //
>> TODO(devlin):
>> Turn on this field trial. See crbug.com/441377.
>> The client-side API to create a field trial, like you're doing here is
>> discouraged.
>>
>
>  It's best to control the trial from the server-side, in which case you
>> don't
>> need this whole block.
>>
>
>  Happy to answer any question on how to do this.
>>
>
> Heard the same from Ilya after this landed, and changed it to be
> appropriate in
> https://codereview.chromium.org/1024493003/. :)
>
> https://codereview.chromium.org/1023673011/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.