Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2857)

Unified Diff: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

Issue 1023673008: Add Media Router issue-banner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js
diff --git a/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js
new file mode 100644
index 0000000000000000000000000000000000000000..77f3d55486b5fb97a60069959c10bb75f454c6e2
--- /dev/null
+++ b/chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js
@@ -0,0 +1,28 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+Polymer('issue-banner', {
+ publish: {
+ /**
+ * The issue to show.
+ *
+ * @attribute issue
+ * @type {media_router.Issue}
+ * @default: undefined
+ */
+ issue: undefined
Jeremy Klein 2015/04/06 18:49:58 nit: The convention I've seen for this has been to
apacible 2015/04/06 21:02:44 Done.
+ },
+
+ created: function() {
+ this.issue = undefined;
Jeremy Klein 2015/04/06 18:49:57 You don't need to do this unless you're actually i
apacible 2015/04/06 21:02:43 Done.
+ },
+
+ onClickAction: function(event, detail, sender) {
Jeremy Klein 2015/04/06 18:49:58 nit: JSDocs
apacible 2015/04/06 21:02:44 Added.
+ this.fire('issue-action-click', {
+ id: this.issue.id,
+ actionType: parseInt(sender.title),
+ helpURL: this.issue.helpURL
+ });
+ }
+});

Powered by Google App Engine
This is Rietveld 408576698