Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: chrome/browser/resources/media_router/elements/issue_banner/issue_banner.js

Issue 1023673008: Add Media Router issue-banner. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 Polymer('issue-banner', {
6 publish: {
7 /**
8 * The issue to show.
9 *
10 * @attribute issue
11 * @type {media_router.Issue}
12 * @default: undefined
13 */
14 issue: undefined
Jeremy Klein 2015/04/06 18:49:58 nit: The convention I've seen for this has been to
apacible 2015/04/06 21:02:44 Done.
15 },
16
17 created: function() {
18 this.issue = undefined;
Jeremy Klein 2015/04/06 18:49:57 You don't need to do this unless you're actually i
apacible 2015/04/06 21:02:43 Done.
19 },
20
21 onClickAction: function(event, detail, sender) {
Jeremy Klein 2015/04/06 18:49:58 nit: JSDocs
apacible 2015/04/06 21:02:44 Added.
22 this.fire('issue-action-click', {
23 id: this.issue.id,
24 actionType: parseInt(sender.title),
25 helpURL: this.issue.helpURL
26 });
27 }
28 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698