Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1023673006: Mac: Reset active texture state when drawing CAOpenGLLayer (Closed)

Created:
5 years, 9 months ago by ccameron
Modified:
5 years, 9 months ago
Reviewers:
vmiura
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Reset active texture state when drawing CAOpenGLLayer When GPU raster is enabled, the active texture state is regularly set to something different at the start of this function. This was observed empirically. Of note is that, in principle, all GL state much be reset. When we use the command buffer to draw inside the CAOpenGLLayer, making the virtual context current will reset all state for us. BUG=423163 Committed: https://crrev.com/d65ea042b964ae0833ecd6ed4f19852c4d334ca6 Cr-Commit-Position: refs/heads/master@{#321613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/common/gpu/image_transport_surface_calayer_mac.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
ccameron
1-line almost-fix. I'm hoping to get the context merge bit in soon (which will make ...
5 years, 9 months ago (2015-03-19 23:57:12 UTC) #2
vmiura
lgtm
5 years, 9 months ago (2015-03-20 02:13:31 UTC) #3
ccameron
Thanks!
5 years, 9 months ago (2015-03-20 18:37:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023673006/1
5 years, 9 months ago (2015-03-20 18:37:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-20 19:16:00 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 19:16:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d65ea042b964ae0833ecd6ed4f19852c4d334ca6
Cr-Commit-Position: refs/heads/master@{#321613}

Powered by Google App Engine
This is Rietveld 408576698