Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1023673005: [Password manager Python tests] Squash INFO logs into one per test (Closed)

Created:
5 years, 9 months ago by vabr (Chromium)
Modified:
5 years, 9 months ago
Reviewers:
engedy
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Password manager Python tests] Squash INFO logs into one per test This is a rather cosmetic change: INFO log level is used to print test summaries. This CL makes the script log one summary instead of 2 consecutive ones. These logs end up in a spreadsheet, and having one line (as opposed to 2) per test is easier to process for statistics. R=engedy@chromium.org BUG=468245 Committed: https://crrev.com/c6232a8638fd305661a497dab069c51b12b7585f Cr-Commit-Position: refs/heads/master@{#321448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/test/data/password_manager/automated_tests/run_tests.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vabr (Chromium)
Hi Balázs, Could you please take a look? Thanks, Vaclav
5 years, 9 months ago (2015-03-19 19:31:54 UTC) #1
engedy
LGTM!
5 years, 9 months ago (2015-03-19 19:56:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023673005/1
5 years, 9 months ago (2015-03-19 20:53:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 22:18:14 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 22:18:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6232a8638fd305661a497dab069c51b12b7585f
Cr-Commit-Position: refs/heads/master@{#321448}

Powered by Google App Engine
This is Rietveld 408576698