Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1023673003: Serializer: another small reorder of root objects. (Closed)

Created:
5 years, 9 months ago by Yang
Modified:
5 years, 9 months ago
Reviewers:
mvstanton, Erik Corry
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Serializer: another small reorder of root objects. I was mistaken, cons strings only occur a lot for custom heap snapshots, not for the default start-up snapshot. R=erik.corry@gmail.com, mvstanton@chromium.org Committed: https://crrev.com/7ccdbcf40c5d32b80221835d454747237f55b62a Cr-Commit-Position: refs/heads/master@{#27312}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/heap/heap.h View 3 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Yang
5 years, 9 months ago (2015-03-19 12:24:03 UTC) #1
Erik Corry
lgtm
5 years, 9 months ago (2015-03-19 12:24:52 UTC) #2
mvstanton
lgtm
5 years, 9 months ago (2015-03-19 13:25:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023673003/1
5 years, 9 months ago (2015-03-19 13:28:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 14:07:46 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 14:07:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ccdbcf40c5d32b80221835d454747237f55b62a
Cr-Commit-Position: refs/heads/master@{#27312}

Powered by Google App Engine
This is Rietveld 408576698