Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1023633003: Verify that the RPH is still alive when handling incoming Notification IPCs. (Closed)

Created:
5 years, 9 months ago by Peter Beverloo
Modified:
5 years, 9 months ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, darin-cc_chromium.org, jam, Mike West, Bernhard Bauer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Verify that the RPH is still alive when handling incoming Notification IPCs. The NotificationMessageFilter still receives a number of IPC messages on the UI thread. It is possible that the IPC message gets handled after the profile has been shut down, so make sure that this isn't the case by verifying that the RenderProcessHost still exists. BUG=457590 Committed: https://crrev.com/d32d9a39c937b4be585af39589d05e903e703c96 Cr-Commit-Position: refs/heads/master@{#321421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/browser/notifications/notification_message_filter.cc View 5 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Peter Beverloo
+tsepez This sounds like a patch up your alley :-). Mind taking a look?
5 years, 9 months ago (2015-03-19 16:01:50 UTC) #2
Tom Sepez
lgtm
5 years, 9 months ago (2015-03-19 17:59:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023633003/1
5 years, 9 months ago (2015-03-19 18:06:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 20:26:52 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 20:28:30 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d32d9a39c937b4be585af39589d05e903e703c96
Cr-Commit-Position: refs/heads/master@{#321421}

Powered by Google App Engine
This is Rietveld 408576698