Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023613002: ServiceWorker: Clean up WebServiceWorkerProviderImpl (Closed)

Created:
5 years, 9 months ago by nhiroki
Modified:
5 years, 9 months ago
Reviewers:
Kunihiko Sakamoto
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ServiceWorker: Clean up WebServiceWorkerProviderImpl This CL... - removes unused getter and header inclusions - simplifies if-statement BUG=n/a TEST=compile Committed: https://crrev.com/13b2c0a31127f1c0dae68a40ce3c8c887548b440 Cr-Commit-Position: refs/heads/master@{#321314}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -29 lines) Patch
M content/child/service_worker/web_service_worker_provider_impl.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/child/service_worker/web_service_worker_provider_impl.cc View 5 chunks +12 lines, -23 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nhiroki
Ptal, thanks!
5 years, 9 months ago (2015-03-19 05:55:42 UTC) #2
Kunihiko Sakamoto
lgtm
5 years, 9 months ago (2015-03-19 07:06:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023613002/1
5 years, 9 months ago (2015-03-19 07:07:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 08:14:34 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 08:15:16 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/13b2c0a31127f1c0dae68a40ce3c8c887548b440
Cr-Commit-Position: refs/heads/master@{#321314}

Powered by Google App Engine
This is Rietveld 408576698