Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 102353004: Allow resource loads inside page unload events (Closed)

Created:
7 years ago by Nate Chapin
Modified:
6 years, 10 months ago
Reviewers:
sof, abarth-chromium
CC:
blink-reviews
Visibility:
Public.

Description

Allow resource loads inside page unload events https://src.chromium.org/viewvc/blink?revision=154852&view=revision appears to have inadvertently caused ResourceFetcher::shouldLoadNewResource() to return false inside of unload events. This is because activeDocumentLoader() has switched to the provisional document loader, but the request is coming from the committed document loader. Test written by sigbjornf@opera.com BUG=321241 TEST=http/tests/xmlhttprequest/xmlhttprequest-unload-sync.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -1 line) Patch
A LayoutTests/http/tests/xmlhttprequest/resources/xmlhttprequest-in-unload-sync.html View 1 chunk +22 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unload-sync.html View 1 chunk +36 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-unload-sync-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Nate Chapin
7 years ago (2013-12-04 00:38:37 UTC) #1
abarth-chromium
lgtm Oh well. It would have been nice to not need to support this case.
7 years ago (2013-12-04 05:58:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/102353004/1
7 years ago (2013-12-04 05:58:58 UTC) #3
sof
Looks fine, tidier way to express it. (That sync XHR is used here is perhaps ...
7 years ago (2013-12-04 06:20:27 UTC) #4
commit-bot: I haz the power
Change committed as 163151
7 years ago (2013-12-04 09:45:30 UTC) #5
sof
6 years, 10 months ago (2014-01-28 15:57:40 UTC) #6
Message was sent while issue was closed.
On 2013/12/04 05:58:48, abarth wrote:
> lgtm
> 
> Oh well.  It would have been nice to not need to support this case.

Beacon might help us here,
https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/Beacon/Overview.html

Powered by Google App Engine
This is Rietveld 408576698