src/objects-inl.h - Issue 1023503003: Revert of Revert "Revert of Fix memory leak caused by field type in descriptor array."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 1023503003: Revert of Revert "Revert of Fix memory leak caused by field type in descriptor array." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index dc739358bce6a2b9c19807d5f0678759c1b30cc4..4ea0a0819b7fae40a51ae1265bdfd210461531ac 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -3136,12 +3136,7 @@

HeapType* DescriptorArray::GetFieldType(int descriptor_number) {

DCHECK(GetDetails(descriptor_number).location() == kField);

- Object* value = GetValue(descriptor_number);

- if (value->IsWeakCell()) {

- if (WeakCell::cast(value)->cleared()) return HeapType::Any();

- value = WeakCell::cast(value)->value();

- }

- return HeapType::cast(value);

+ return HeapType::cast(GetValue(descriptor_number));

}

« no previous file with comments | « src/objects.cc ('k') | src/property.h » ('j') | no next file with comments »