Add flag to WaitForJavaScriptExpression to reduce the exception verbosity.

Add flag to WaitForJavaScriptExpression to reduce the exception verbosity.

BUG=

Committed: https://crrev.com/c24bf33e4284111efcb1ef9f647a9c18384be166
Cr-Commit-Position: refs/heads/master@{#321239}

[ariblue, 2015-03-18 21:37:09]

ariblue@google.com changed reviewers:
+ nednguyen@google.com

[nednguyen, 2015-03-18 21:39:48]

https://codereview.chromium.org/1023493002/diff/1/tools/telemetry/telemetry/c...
File tools/telemetry/telemetry/core/web_contents.py (right):

https://codereview.chromium.org/1023493002/diff/1/tools/telemetry/telemetry/c...
tools/telemetry/telemetry/core/web_contents.py:38: def
WaitForJavaScriptExpression(self, expr, timeout, verbose_errors=True):
Can you improve the pydoc to explain what verbose_errors does?

And may be rename verbose_erros to dumping_page_state_on_error ?

[ariblue, 2015-03-18 22:13:38]

https://codereview.chromium.org/1023493002/diff/1/tools/telemetry/telemetry/c...
File tools/telemetry/telemetry/core/web_contents.py (right):

https://codereview.chromium.org/1023493002/diff/1/tools/telemetry/telemetry/c...
tools/telemetry/telemetry/core/web_contents.py:38: def
WaitForJavaScriptExpression(self, expr, timeout, verbose_errors=True):
On 2015/03/18 21:39:48, nednguyen wrote:
> Can you improve the pydoc to explain what verbose_errors does?
> 
> And may be rename verbose_erros to dumping_page_state_on_error ?

Done. Re-named it "dump_page_state_on_timeout".

[nednguyen, 2015-03-18 22:15:26]

lgtm

[ariblue, 2015-03-18 22:25:23]

The CQ bit was checked by ariblue@google.com

[commit-bot: I haz the power, 2015-03-18 22:28:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1023493002/20001

[commit-bot: I haz the power, 2015-03-18 22:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-18 22:33:02]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ariblue, 2015-03-18 22:44:38]

The CQ bit was checked by ariblue@google.com

[ariblue, 2015-03-18 22:44:38]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1023493002/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2015-03-18 22:45:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1023493002/40001

[commit-bot: I haz the power, 2015-03-19 00:00:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-19 00:00:43]

Patchset 3 (id:??) landed as
https://crrev.com/c24bf33e4284111efcb1ef9f647a9c18384be166
Cr-Commit-Position: refs/heads/master@{#321239}