Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1023483002: Revert of Log force-alt-protocols command line flag usage. (patchset #2 id:20001 of https://coderev… (Closed)

Created:
5 years, 9 months ago by Bence
Modified:
5 years, 9 months ago
Reviewers:
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "Log force-alt-protocols command line flag usage". Revert of "Log force-alt-protocols command line flag usage" (patchset #2 id:20001 of https://codereview.chromium.org/879863004/). Created manually by git revert ; git cl upload. Reason for revert: Reverting bogus CL. base::RecordAction cannot be called on the IO thread. This CL actually causes debug build Chromium to crash upon startup if invoked with the --use-spdy=force-alt-protocols command line flag. Nothing else in io_thread.cc seems to be using "base/metrics/user_metrics.h", so it seems to be safe to remove. Original issue's description: > Log force-alt-protocols command line flag usage. > > BUG=452514 > > Committed: https://crrev.com/493bc568527caeab93a173e4feea85c0c86c439e > Cr-Commit-Position: refs/heads/master@{#313566} TBR=rch@chromium.org,asvitkine@chromium.org BUG=452514 Committed: https://crrev.com/206a16f0cdea031978c07fa6231a4b09be03db31 Cr-Commit-Position: refs/heads/master@{#321343}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M chrome/browser/io_thread.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023483002/1
5 years, 9 months ago (2015-03-19 12:48:48 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 12:57:29 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:58:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/206a16f0cdea031978c07fa6231a4b09be03db31
Cr-Commit-Position: refs/heads/master@{#321343}

Powered by Google App Engine
This is Rietveld 408576698