Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1023443007: Make sure Blink WebRTCSessionDescriptionRequest and WebRTCVoidRequest are deleted on the correct th… (Closed)

Created:
5 years, 9 months ago by perkj_chrome
Modified:
5 years, 9 months ago
CC:
chromium-reviews, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make sure Blink WebRTCSessionDescriptionRequest and WebRTCVoidRequest are deleted on the correct thread in RTCPeerConnectionHandler. Blink objects must always be destroyed on the main render thread. Since the object holding WebRTCSessionDescriptionRequest and WebRTCVoidRequest in rtc_peerconnection_handler.cc are refcounted, the destructor is not ensured to run on the main render thread. BUG=470047 Committed: https://crrev.com/44acfec4479754f0314e16251af45bb9453e0ba8 Cr-Commit-Position: refs/heads/master@{#321989}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M content/renderer/media/rtc_peer_connection_handler.cc View 4 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perkj_chrome
please
5 years, 9 months ago (2015-03-24 10:59:09 UTC) #2
tommi (sloooow) - chröme
lgtm
5 years, 9 months ago (2015-03-24 12:29:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023443007/1
5 years, 9 months ago (2015-03-24 12:29:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-24 13:29:03 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-24 13:29:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44acfec4479754f0314e16251af45bb9453e0ba8
Cr-Commit-Position: refs/heads/master@{#321989}

Powered by Google App Engine
This is Rietveld 408576698