Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1023413002: Autofill: Refactor some FormFieldData pickling code. (Closed)

Created:
5 years, 9 months ago by Lei Zhang
Modified:
5 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Refactor some FormFieldData pickling code. Committed: https://crrev.com/fb891b7eb736210fb177a9e8b24fd2b0c666547f Cr-Commit-Position: refs/heads/master@{#321876}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -103 lines) Patch
M components/autofill/core/common/form_field_data.cc View 1 5 chunks +54 lines, -53 lines 0 comments Download
M components/autofill/core/common/form_field_data_unittest.cc View 2 chunks +52 lines, -50 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
Lei Zhang
5 years, 9 months ago (2015-03-23 18:08:09 UTC) #3
Evan Stade
lgtm https://codereview.chromium.org/1023413002/diff/20001/components/autofill/core/common/form_field_data.cc File components/autofill/core/common/form_field_data.cc (right): https://codereview.chromium.org/1023413002/diff/20001/components/autofill/core/common/form_field_data.cc#newcode55 components/autofill/core/common/form_field_data.cc:55: return (iter->ReadString16(&field_data->label) && nit: remove outer parens https://codereview.chromium.org/1023413002/diff/20001/components/autofill/core/common/form_field_data.cc#newcode70 ...
5 years, 9 months ago (2015-03-23 19:15:15 UTC) #4
Lei Zhang
https://codereview.chromium.org/1023413002/diff/20001/components/autofill/core/common/form_field_data.cc File components/autofill/core/common/form_field_data.cc (right): https://codereview.chromium.org/1023413002/diff/20001/components/autofill/core/common/form_field_data.cc#newcode55 components/autofill/core/common/form_field_data.cc:55: return (iter->ReadString16(&field_data->label) && On 2015/03/23 19:15:14, Evan Stade wrote: ...
5 years, 9 months ago (2015-03-23 21:00:45 UTC) #5
Lei Zhang
5 years, 9 months ago (2015-03-23 21:00:57 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1023413002/40001
5 years, 9 months ago (2015-03-23 21:02:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-23 22:24:57 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 22:25:47 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fb891b7eb736210fb177a9e8b24fd2b0c666547f
Cr-Commit-Position: refs/heads/master@{#321876}

Powered by Google App Engine
This is Rietveld 408576698