Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: Source/core/css/SiblingTraversalStrategies.h

Issue 1023393002: Cache element indices for :nth-child and :nth-last-child selectors. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Missing initializer and incorrect assert. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/SiblingTraversalStrategies.h
diff --git a/Source/core/css/SiblingTraversalStrategies.h b/Source/core/css/SiblingTraversalStrategies.h
index e63a66185ae4ff48e4ccace4008fe6d8adff2fea..1e008dba5fda36e1c053fe4b5b43ba61e10e51af 100644
--- a/Source/core/css/SiblingTraversalStrategies.h
+++ b/Source/core/css/SiblingTraversalStrategies.h
@@ -29,8 +29,10 @@
#ifndef SiblingTraversalStrategies_h
#define SiblingTraversalStrategies_h
+#include "core/dom/Document.h"
#include "core/dom/Element.h"
#include "core/dom/ElementTraversal.h"
+#include "core/dom/NthIndexCache.h"
#include "core/style/ComputedStyle.h"
namespace blink {
@@ -79,6 +81,9 @@ inline bool DOMSiblingTraversalStrategy::isLastOfType(Element& element, const Qu
inline int DOMSiblingTraversalStrategy::countElementsBefore(Element& element) const
{
+ if (NthIndexCache* nthIndexCache = element.document().nthIndexCache())
+ return nthIndexCache->nthChildIndex(element) - 1;
+
int count = 0;
for (const Element* sibling = ElementTraversal::previousSibling(element); sibling; sibling = ElementTraversal::previousSibling(*sibling))
count++;
@@ -96,6 +101,9 @@ inline int DOMSiblingTraversalStrategy::countElementsOfTypeBefore(Element& eleme
inline int DOMSiblingTraversalStrategy::countElementsAfter(Element& element) const
{
+ if (NthIndexCache* nthIndexCache = element.document().nthIndexCache())
+ return nthIndexCache->nthLastChildIndex(element) - 1;
+
int count = 0;
for (const Element* sibling = ElementTraversal::nextSibling(element); sibling; sibling = ElementTraversal::nextSibling(*sibling))
++count;
« no previous file with comments | « Source/core/core.gypi ('k') | Source/core/dom/ContainerNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698